From: Richard Genoud <richard.genoud@gmail.com>
To: spi-devel-general@lists.sourceforge.net
Cc: "David Brownell" <dbrownell@users.sourceforge.net>,
"Grant Likely" <grant.likely@secretlab.ca>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-kernel@vger.kernel.org,
"Richard Genoud" <richard.genoud@gmail.com>
Subject: [PATCH 1/2] spi_imx.c: CSPI3 irq is 0 on imx25
Date: Thu, 23 Dec 2010 12:12:09 +0100 [thread overview]
Message-ID: <1293102730-32528-1-git-send-email-richard.genoud@gmail.com> (raw)
On imx25 soc, MX25_INT_CSPI3 is 0
(cf arch/arm/plat-mxc/include/mach/mx25.h).
So, the test (spi_imx->irq <= 0) returned an error
for this platform.
This patch corrects this behaviour.
Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
---
drivers/spi/spi_imx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/spi/spi_imx.c b/drivers/spi/spi_imx.c
index 55a38e2..793ae99 100644
--- a/drivers/spi/spi_imx.c
+++ b/drivers/spi/spi_imx.c
@@ -847,7 +847,7 @@ static int __devinit spi_imx_probe(struct platform_device *pdev)
}
spi_imx->irq = platform_get_irq(pdev, 0);
- if (spi_imx->irq <= 0) {
+ if (spi_imx->irq < 0) {
ret = -EINVAL;
goto out_iounmap;
}
--
1.7.1
next reply other threads:[~2010-12-23 11:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-23 11:12 Richard Genoud [this message]
2010-12-23 11:12 ` [PATCH 2/2] spi_imx.c: TRIVIAL mx25 & mx35 SPI_VER is 0.7 Richard Genoud
2010-12-23 14:29 ` Uwe Kleine-König
2010-12-23 14:38 ` Richard Genoud
2010-12-23 19:03 ` Grant Likely
2010-12-23 19:01 ` Grant Likely
2010-12-23 18:59 ` [PATCH 1/2] spi_imx.c: CSPI3 irq is 0 on imx25 Grant Likely
2011-01-06 11:26 ` Richard Genoud
2011-01-07 14:26 ` [PATCH] spi_imx.c: correct the test on platform_get_irq() return value Richard Genoud
2011-01-07 15:26 ` Grant Likely
2011-01-07 16:41 ` Richard Genoud
2011-01-07 16:58 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1293102730-32528-1-git-send-email-richard.genoud@gmail.com \
--to=richard.genoud@gmail.com \
--cc=dbrownell@users.sourceforge.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).