From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers Date: Wed, 06 Apr 2011 19:07:08 +0100 Message-ID: <1302113228.2840.29.camel@bwh-desktop> References: <20110401104756.2f5c6f7a@debxo> <20110401235239.GE29397@sortiz-mobl> <20110404100314.GC2751@sortiz-mobl> <20110405030428.GB29522@ponder.secretlab.ca> <20110406152322.GA2757@sortiz-mobl> <20110406155805.GA20095@suse.de> <20110406170537.GB2757@sortiz-mobl> <1302110209.2840.20.camel@bwh-desktop> <20110406175113.GC2757@sortiz-mobl> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Greg KH , Grant Likely , Andres Salomon , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Brown , khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, Peter Korsgaard , Mauro Carvalho Chehab , David Brownell , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Mocean Laboratories To: Samuel Ortiz Return-path: In-Reply-To: <20110406175113.GC2757@sortiz-mobl> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-spi.vger.kernel.org On Wed, 2011-04-06 at 19:51 +0200, Samuel Ortiz wrote: > Hi Ben, > > On Wed, Apr 06, 2011 at 06:16:49PM +0100, Ben Hutchings wrote: > > > So, adding an MFD cell pointer to the device structure allows us to cleanly > > > pass both pieces of information, while keeping all the MFD sub drivers > > > independant from the MFD core if they want/can. > > > > Why isn't an MFD the parent of its component devices? > It actually is. How would that help here ? I was thinking you could encode the component address in the platform_device name (just as the bus address is the name of a normal bus device). That plus the parent device pointer would be sufficient information to look up the mfd_cell. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.