linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: [PATCH 1/6] ARM: mxc: remove unnecessary header file inclusion from gpio.h
Date: Fri,  8 Jul 2011 16:27:29 +0800	[thread overview]
Message-ID: <1310113654-25887-2-git-send-email-shawn.guo@linaro.org> (raw)
In-Reply-To: <1310113654-25887-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

The mach/gpio.h is included by asm/gpio.h, and in turn it gets
included all over the place.  Including unnecessary headers there
brings indirect inclusion trouble.

As an example, spi-imx calls cpu_is_mx21() but never explicitly
includes mach/hardware.h.  However it works because the header is
included in mach/gpio.h.

The patch cleans the unnecessary header file from mach/gpio.h,
and includes headers explicitly where needed.

Signed-off-by: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
 arch/arm/plat-mxc/include/mach/gpio.h |    2 --
 drivers/spi/spi-imx.c                 |    1 +
 2 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/arm/plat-mxc/include/mach/gpio.h b/arch/arm/plat-mxc/include/mach/gpio.h
index 31c820c..5bb02af 100644
--- a/arch/arm/plat-mxc/include/mach/gpio.h
+++ b/arch/arm/plat-mxc/include/mach/gpio.h
@@ -19,8 +19,6 @@
 #ifndef __ASM_ARCH_MXC_GPIO_H__
 #define __ASM_ARCH_MXC_GPIO_H__
 
-#include <linux/spinlock.h>
-#include <mach/hardware.h>
 #include <asm-generic/gpio.h>
 
 
diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index 69d6dba..7097d43 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -36,6 +36,7 @@
 #include <linux/types.h>
 
 #include <mach/spi.h>
+#include <mach/hardware.h>
 
 #define DRIVER_NAME "spi_imx"
 
-- 
1.7.4.1

  parent reply	other threads:[~2011-07-08  8:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-08  8:27 [PATCH 0/6] Add device tree support for imx spi driver Shawn Guo
     [not found] ` <1310113654-25887-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-07-08  8:27   ` Shawn Guo [this message]
2011-07-08  8:27   ` [PATCH 2/6] spi/imx: use soc name in spi device type naming scheme Shawn Guo
     [not found]     ` <1310113654-25887-3-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-07-08 10:58       ` Sascha Hauer
     [not found]         ` <20110708105851.GF6069-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-07-09  7:00           ` Shawn Guo
     [not found]             ` <20110709070001.GE13962-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-07-11  6:32               ` Sascha Hauer
2011-07-08  8:27   ` [PATCH 3/6] spi/imx: copy gpio number passed by platform data into driver private data Shawn Guo
2011-07-08  8:27   ` [PATCH 4/6] dt: add helper function to read u32 arrays Shawn Guo
2011-07-08  8:27   ` [PATCH 5/6] dt: add empty of_property_read_u32[_array] for non-dt Shawn Guo
     [not found]     ` <1310113654-25887-6-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-07-08 12:33       ` Rob Herring
2011-07-08 18:49     ` Grant Likely
2011-07-08  8:27   ` [PATCH 6/6] spi/imx: add device tree probe support Shawn Guo
2011-07-08 19:01 ` [PATCH 0/6] Add device tree support for imx spi driver Grant Likely
     [not found]   ` <20110708190142.GD9070-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-07-09  6:44     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310113654-25887-2-git-send-email-shawn.guo@linaro.org \
    --to=shawn.guo-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).