linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roland Stigge <stigge@antcom.de>
To: cjb@laptop.org, grant.likely@secretlab.ca,
	rob.herring@calxeda.com, rmk+kernel@arm.linux.org.uk,
	ulf.hansson@stericsson.com, linus.walleij@linaro.org,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	aletes.xgr@gmail.com, linux-arm-kernel@lists.infradead.org,
	spi-devel-general@lists.sourceforge.net
Cc: Roland Stigge <stigge@antcom.de>
Subject: [PATCH] spi: spi-pl022: Adjust probe() to of_get_named_gpio() returning -EPROBE_DEFER
Date: Mon, 18 Jun 2012 11:20:19 +0200	[thread overview]
Message-ID: <1340011219-31657-1-git-send-email-stigge@antcom.de> (raw)

The patch to gpiolib-of.c providing -EPROBE_DEFER as a hint to defer
of_get_named_gpio*() to a later probe() breaks spi-pl022.c.

This patch adjusts to this change, using -EPROBE_DEFER as indication to defer.

Signed-off-by: Roland Stigge <stigge@antcom.de>

---
Applies to 3.5-rc3

Should this patch be joined with gpiolib-of's patch to of_get_named_gpio()? Or
should they just be issued as a series?

 drivers/spi/spi-pl022.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.orig/drivers/spi/spi-pl022.c
+++ linux-2.6/drivers/spi/spi-pl022.c
@@ -2075,7 +2075,7 @@ pl022_probe(struct amba_device *adev, co
 	for (i = 0; i < num_cs; i++) {
 		int cs_gpio = of_get_named_gpio(np, "cs-gpios", i);
 
-		if (cs_gpio == -ENODEV) {
+		if (cs_gpio == -EPROBE_DEFER) {
 			status = -EPROBE_DEFER;
 			goto err_no_gpio;
 		}

             reply	other threads:[~2012-06-18  9:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-18  9:20 Roland Stigge [this message]
2012-06-18 11:13 ` [PATCH] spi: spi-pl022: Adjust probe() to of_get_named_gpio() returning -EPROBE_DEFER Roland Stigge
2012-06-18 11:47 ` Linus Walleij
2012-06-18 11:51   ` Alexandre Pereira da Silva
     [not found]     ` <CAAAP30GAwQZtjAjtX=Q8K0Szo83QwqCZNtr09GxrgcvcR-CKeA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-18 12:56       ` Roland Stigge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340011219-31657-1-git-send-email-stigge@antcom.de \
    --to=stigge@antcom.de \
    --cc=aletes.xgr@gmail.com \
    --cc=cjb@laptop.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=rob.herring@calxeda.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=ulf.hansson@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).