linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jun Chen <jun.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Grant Likely
	<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	ken.k.mills-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	chao bi <chao.bi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	sylvain.centelles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH] SPI: SSP SPI Controller driver
Date: Tue, 11 Dec 2012 09:30:47 -0500	[thread overview]
Message-ID: <1355236247.1435.12.camel@chenjun-workstation> (raw)
In-Reply-To: <20121206141938.0100f06f-Z/y2cZnRghHXmaaqVzeoHQ@public.gmane.org>

On Thu, 2012-12-06 at 14:19 +0000, Alan Cox wrote:

> > > +late_initcall(intel_mid_ssp_spi_init);
> > 
> > Why late_initcall()? module_init() should be sufficient. Or better yet
> > replace the init and exit functions with module_pci_driver()
> 
> Thats a legacy of the old SPI code not handling bus and device
> registration in random orders. So it's no longer needed I believe.
> 
> Alan

We use the late_initcall because we want init the spi driver after
finished the dma driver with fs_initcall. Now we can not test the 
module_pci_driver replace the late_initcall because our kernel version
is not brach 3.7. So maybe we can use old the late_initcall and update
this code in the further, Do you agree?


------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d

  parent reply	other threads:[~2012-12-11 14:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21  2:16 [PATCH] SPI: SSP SPI Controller driver chao bi
2012-11-21 12:08 ` Shubhrajyoti Datta
     [not found]   ` <CAM=Q2cvoEMScnCmfrhoAueZ8bfPCX90TxZmsSigfeRbGeXbzMA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-22  3:26     ` Bi, Chao
     [not found]       ` <253F3AA5ECB4EC43A2CA0147545F67F2102B5D40-0J0gbvR4kTiiAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-11-22  6:54         ` Shubhrajyoti Datta
     [not found]           ` <CAM=Q2cszn_OoTyYiUVSj3NvpxJq+wSUnMJVcwWOdV2EzDviLVw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-22  8:13             ` Bi, Chao
2012-11-21 12:14 ` Shubhrajyoti Datta
     [not found]   ` <CAM=Q2cu6ReS-6sJxdacnw=FYGdoFed9bM1gA6yFEtmVjs8KQTA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-21 12:26     ` Alan Cox
     [not found]       ` <20121121122630.13fc2087-Z/y2cZnRghHXmaaqVzeoHQ@public.gmane.org>
2012-11-22  7:01         ` Shubhrajyoti Datta
     [not found]           ` <CAM=Q2cuCZni2DyzDux-E5H4-djgNrUURTYJ+f=_oMBeJE7eGMw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-22 11:04             ` Alan Cox
2012-12-06 12:38 ` Grant Likely
2012-12-06 14:19   ` Alan Cox
     [not found]     ` <20121206141938.0100f06f-Z/y2cZnRghHXmaaqVzeoHQ@public.gmane.org>
2012-12-11 14:30       ` Jun Chen [this message]
2012-12-11  2:00   ` chao bi
2012-12-11 16:36     ` Grant Likely
2012-12-11  8:58   ` chao bi
2012-12-11 16:46     ` Grant Likely
2012-12-13  9:09       ` chao bi
2012-12-16 21:32         ` Grant Likely
2012-12-17  8:24           ` chao bi
2012-12-17  8:58     ` Linus Walleij
2012-12-17 11:23 ` Linus Walleij
     [not found]   ` <CACRpkdad3fHxWRpRqD-eP8-sKKexN+s-JZCT6XLggv92Q=5kMA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-18  5:47     ` chao bi
2012-12-20 15:32       ` Linus Walleij
2013-01-09  4:25       ` Vinod Koul
     [not found]         ` <20130109042535.GL19691-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-01-10 11:52           ` Linus Walleij
  -- strict thread matches above, loose matches on Subject: below --
2012-11-06  9:11 chao bi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1355236247.1435.12.camel@chenjun-workstation \
    --to=jun.d.chen-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=chao.bi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
    --cc=ken.k.mills-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=sylvain.centelles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).