From: Anatolij Gustschin <agust-ynQEQJNshbs@public.gmane.org>
To: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: [PATCH] spi: spi-mpc512x-psc: don't use obsolet cell-index property
Date: Fri, 21 Dec 2012 15:43:01 +0100 [thread overview]
Message-ID: <1356100981-18685-1-git-send-email-agust@denx.de> (raw)
Use unique PSCx register base offset to obtain the
SPI PSC number used for SPI bus id.
Signed-off-by: Anatolij Gustschin <agust-ynQEQJNshbs@public.gmane.org>
---
drivers/spi/spi-mpc512x-psc.c | 17 +++++++++++------
1 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mpc512x-psc.c
index 0a1e39e..844d68f 100644
--- a/drivers/spi/spi-mpc512x-psc.c
+++ b/drivers/spi/spi-mpc512x-psc.c
@@ -523,16 +523,21 @@ static int __devinit mpc512x_psc_spi_of_probe(struct platform_device *op)
/* get PSC id (0..11, used by port_config) */
if (op->dev.platform_data == NULL) {
- const u32 *psc_nump;
+ u32 reg;
+ int err;
- psc_nump = of_get_property(op->dev.of_node, "cell-index", NULL);
- if (!psc_nump || *psc_nump > 11) {
- dev_err(&op->dev, "mpc512x_psc_spi: Device node %s "
- "has invalid cell-index property\n",
+ err = of_property_read_u32(op->dev.of_node, "reg", ®);
+ if (err) {
+ dev_err(&op->dev, "Can't read reg property: %d\n", err);
+ return err;
+ }
+
+ id = (reg & 0xf00) >> 8;
+ if (id > 11) {
+ dev_err(&op->dev, "node %s has invalid reg property\n",
op->dev.of_node->full_name);
return -EINVAL;
}
- id = *psc_nump;
}
return mpc512x_psc_spi_do_probe(&op->dev, (u32) regaddr64, (u32) size64,
--
1.7.7.6
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
next reply other threads:[~2012-12-21 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 14:43 Anatolij Gustschin [this message]
[not found] ` <1356100981-18685-1-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
2012-12-21 14:48 ` [PATCH] spi: spi-mpc512x-psc: don't use obsolet cell-index property Grant Likely
2012-12-21 19:29 ` Grant Likely
2013-01-10 23:12 ` Anatolij Gustschin
2013-01-10 23:26 ` [PATCH v2] " Anatolij Gustschin
2013-01-11 0:05 ` Anatolij Gustschin
[not found] ` <1357862748-14130-1-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
2013-02-05 14:09 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356100981-18685-1-git-send-email-agust@denx.de \
--to=agust-ynqeqjnshbs@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).