From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-kernel@vger.kernel.org,
spi-devel-general@lists.sourceforge.net,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH] spi: Ensure memory used for spi_write_then_read() is DMA safe
Date: Sun, 27 Jan 2013 14:35:04 +0800 [thread overview]
Message-ID: <1359268504-24937-1-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
Use GFP_DMA in order to ensure that the memory we allocate for transfers
in spi_write_then_read() can be DMAed. On most platforms this will have
no effect.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/spi/spi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 19ee901..14d0fba 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -1656,7 +1656,8 @@ int spi_write_then_read(struct spi_device *spi,
* using the pre-allocated buffer or the transfer is too large.
*/
if ((n_tx + n_rx) > SPI_BUFSIZ || !mutex_trylock(&lock)) {
- local_buf = kmalloc(max((unsigned)SPI_BUFSIZ, n_tx + n_rx), GFP_KERNEL);
+ local_buf = kmalloc(max((unsigned)SPI_BUFSIZ, n_tx + n_rx),
+ GFP_KERNEL | GFP_DMA);
if (!local_buf)
return -ENOMEM;
} else {
--
1.7.10.4
next reply other threads:[~2013-01-27 6:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-27 6:35 Mark Brown [this message]
2013-02-05 14:21 ` [PATCH] spi: Ensure memory used for spi_write_then_read() is DMA safe Grant Likely
2025-03-20 11:43 ` Petr Tesarik
2025-03-20 12:29 ` Mark Brown
2025-03-20 13:35 ` Arnd Bergmann
2025-03-20 14:35 ` Petr Tesarik
2025-03-20 15:34 ` Mark Brown
2025-03-20 16:08 ` Petr Tesarik
2025-03-20 18:55 ` Mark Brown
2025-03-20 14:42 ` Mark Brown
2025-03-20 16:30 ` Arnd Bergmann
2025-03-20 18:39 ` Mark Brown
2025-03-21 12:41 ` Arnd Bergmann
2025-03-21 14:13 ` Petr Tesarik
2025-03-21 21:21 ` Arnd Bergmann
2025-03-21 14:45 ` Mark Brown
2025-03-21 19:42 ` Arnd Bergmann
2025-03-26 16:20 ` Mark Brown
2025-03-26 21:45 ` Arnd Bergmann
2025-03-27 15:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359268504-24937-1-git-send-email-broonie@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).