From: Gerhard Sittig <gsi-ynQEQJNshbs@public.gmane.org>
To: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Gerhard Sittig <gsi-ynQEQJNshbs@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
dzu-ynQEQJNshbs@public.gmane.org
Subject: [PATCH v1 0/3] spi: mpc512x: increase throughput, use subsystem queue
Date: Mon, 3 Jun 2013 14:03:48 +0200 [thread overview]
Message-ID: <1370261031-28572-1-git-send-email-gsi@denx.de> (raw)
This change set modifies the MPC512x PSC SPI master driver:
- it increases SPI throughput by eliminating delays in the inner RX/TX
routine during iteration over the transfer's data, and reducing delays
at the very end of a transfer -- while the conditions for as well as
the handling of previously handled exceptional situations are kept
- it makes the SPI master switch to the common subsystem's logic to
queue messages between the callers' emission and the master's
transmission (and drops the master's private queue mechanism)
Gerhard Sittig (3):
spi: mpc512x: minor prep before feature change
spi: mpc512x: improve throughput in the RX/TX func
spi: mpc512x: use the SPI subsystem's message queue
drivers/spi/spi-mpc512x-psc.c | 341 ++++++++++++++++++++++-------------------
1 file changed, 186 insertions(+), 155 deletions(-)
known issue:
the first patch raises a checkpatch warning because it merely renames
variables but keeps the code path and the existing diagnostics message
in place
a subsequent change in the second patch rephrases the RX/TX routine's
code path and changes the diagnostics message for that condition to
something which doesn't have the checkpatch issue (keeps the user
visible text on one line) and thus passes the test
WARNING: quoted string split across lines
#113: FILE: drivers/spi/spi-mpc512x-psc.c:193:
dev_warn(&spi->dev, "expected %d bytes in rx fifo "
+ "but got %d\n", txcount, rxcount);
total: 0 errors, 1 warnings, 130 lines checked
--
1.7.10.4
------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite
It's a free troubleshooting tool designed for production
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap2
next reply other threads:[~2013-06-03 12:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 12:03 Gerhard Sittig [this message]
[not found] ` <1370261031-28572-1-git-send-email-gsi-ynQEQJNshbs@public.gmane.org>
2013-06-03 12:03 ` [PATCH v1 1/3] spi: mpc512x: minor prep before feature change Gerhard Sittig
[not found] ` <20130604172059.GI31367@sirena.org.uk>
[not found] ` <20130604172059.GI31367-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-06-04 18:45 ` Gerhard Sittig
2013-06-03 12:03 ` [PATCH v1 2/3] spi: mpc512x: improve throughput in the RX/TX func Gerhard Sittig
2013-06-03 12:03 ` [PATCH v1 3/3] spi: mpc512x: use the SPI subsystem's message queue Gerhard Sittig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370261031-28572-1-git-send-email-gsi@denx.de \
--to=gsi-ynqeqjnshbs@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=dzu-ynQEQJNshbs@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).