* [PATCH] spi/fsl-espi: fix the return value judgment of irq_of_parse_and_map.
@ 2013-12-11 5:09 Hou Zhiqiang
[not found] ` <1386738580-9930-1-git-send-email-b48286-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Hou Zhiqiang @ 2013-12-11 5:09 UTC (permalink / raw)
To: linux-spi-u79uwXL29TY76Z2rM5mHXA
Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A,
grant.likely-s3s/WqlpOiPyB63q8FvJNQ,
scottwood-KZfg59tc24xl57MIdRCFDg,
Mingkai.Hu-KZfg59tc24xl57MIdRCFDg, Hou Zhiqiang
Signed-off-by: Hou Zhiqiang <b48286-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
drivers/spi/spi-fsl-espi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-fsl-espi.c b/drivers/spi/spi-fsl-espi.c
index 80d8f40..8106006 100644
--- a/drivers/spi/spi-fsl-espi.c
+++ b/drivers/spi/spi-fsl-espi.c
@@ -705,7 +705,7 @@ static int of_fsl_espi_probe(struct platform_device *ofdev)
goto err;
irq = irq_of_parse_and_map(np, 0);
- if (!ret) {
+ if (!irq) {
ret = -EINVAL;
goto err;
}
--
1.8.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1386738580-9930-1-git-send-email-b48286-KZfg59tc24xl57MIdRCFDg@public.gmane.org>]
* Re: [PATCH] spi/fsl-espi: fix the return value judgment of irq_of_parse_and_map. [not found] ` <1386738580-9930-1-git-send-email-b48286-KZfg59tc24xl57MIdRCFDg@public.gmane.org> @ 2013-12-11 8:49 ` Grant Likely 2013-12-11 11:07 ` Mark Brown 1 sibling, 0 replies; 3+ messages in thread From: Grant Likely @ 2013-12-11 8:49 UTC (permalink / raw) To: Hou Zhiqiang; +Cc: linux-spi, Mark Brown, Scott Wood, Mingkai Hu On Wed, Dec 11, 2013 at 5:09 AM, Hou Zhiqiang <b48286-KZfg59tc24xl57MIdRCFDg@public.gmane.org> wrote: > Signed-off-by: Hou Zhiqiang <b48286-KZfg59tc24xl57MIdRCFDg@public.gmane.org> > --- > drivers/spi/spi-fsl-espi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-fsl-espi.c b/drivers/spi/spi-fsl-espi.c > index 80d8f40..8106006 100644 > --- a/drivers/spi/spi-fsl-espi.c > +++ b/drivers/spi/spi-fsl-espi.c > @@ -705,7 +705,7 @@ static int of_fsl_espi_probe(struct platform_device *ofdev) > goto err; > > irq = irq_of_parse_and_map(np, 0); > - if (!ret) { > + if (!irq) { > ret = -EINVAL; > goto err; > } Obviously correct. Acked-by: Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > -- > 1.8.4.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spi/fsl-espi: fix the return value judgment of irq_of_parse_and_map. [not found] ` <1386738580-9930-1-git-send-email-b48286-KZfg59tc24xl57MIdRCFDg@public.gmane.org> 2013-12-11 8:49 ` Grant Likely @ 2013-12-11 11:07 ` Mark Brown 1 sibling, 0 replies; 3+ messages in thread From: Mark Brown @ 2013-12-11 11:07 UTC (permalink / raw) To: Hou Zhiqiang Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, grant.likely-s3s/WqlpOiPyB63q8FvJNQ, scottwood-KZfg59tc24xl57MIdRCFDg, Mingkai.Hu-KZfg59tc24xl57MIdRCFDg [-- Attachment #1: Type: text/plain, Size: 159 bytes --] On Wed, Dec 11, 2013 at 01:09:40PM +0800, Hou Zhiqiang wrote: > Signed-off-by: Hou Zhiqiang <b48286-KZfg59tc24xl57MIdRCFDg@public.gmane.org> Applied, thanks. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-11 11:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-11 5:09 [PATCH] spi/fsl-espi: fix the return value judgment of irq_of_parse_and_map Hou Zhiqiang
[not found] ` <1386738580-9930-1-git-send-email-b48286-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-12-11 8:49 ` Grant Likely
2013-12-11 11:07 ` Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).