linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-sh@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@linux-m68k.org>,
	Hiep Cao Minh <cm-hiep@jinso.co.jp>
Subject: [PATCH 1/2] spi: rspi: Fix NULL pointer dereference on SH7757
Date: Mon, 23 Dec 2013 19:34:23 +0100	[thread overview]
Message-ID: <1387823664-32318-1-git-send-email-geert+renesas@linux-m68k.org> (raw)

SH7757 doesn't pass platform data, in which case spi-rspi uses default
parameters.

However, commit 5ce0ba88650f2606244a761d92e2b725f4ab3583 ("spi: rcar: add
Renesas QSPI support on RSPI") added a new user of the platform data, but
forgot to check for its validity first, causing a NULL pointer dereference
on SH7757.

Add the missing check to fix this.

Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
Cc: Hiep Cao Minh <cm-hiep@jinso.co.jp>
---
This fixes a regression introduced in v3.13-rc1

 drivers/spi/spi-rspi.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-rspi.c b/drivers/spi/spi-rspi.c
index cfdbb422a40a..9e0301014f48 100644
--- a/drivers/spi/spi-rspi.c
+++ b/drivers/spi/spi-rspi.c
@@ -948,8 +948,9 @@ static int rspi_probe(struct platform_device *pdev)
 	INIT_WORK(&rspi->ws, rspi_work);
 	init_waitqueue_head(&rspi->wait);
 
-	master->num_chipselect = rspi_pd->num_chipselect;
-	if (!master->num_chipselect)
+	if (rspi_pd && rspi_pd->num_chipselect)
+		master->num_chipselect = rspi_pd->num_chipselect;
+	else
 		master->num_chipselect = 2; /* default */
 
 	master->bus_num = pdev->id;
-- 
1.7.9.5


             reply	other threads:[~2013-12-23 18:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-23 18:34 Geert Uytterhoeven [this message]
2013-12-23 18:34 ` [PATCH 2/2] spi: rspi: Fix typo when clearing SPSR_OVRF Geert Uytterhoeven
     [not found]   ` <1387823664-32318-2-git-send-email-geert+renesas-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2013-12-24  2:59     ` Simon Horman
2013-12-24  9:26       ` Geert Uytterhoeven
     [not found]         ` <CAMuHMdWiJPF2NU+ME=CLMygvABZ_fcTyr7ggdQtFKbOGhCA0+w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-27  2:16           ` Simon Horman
     [not found]             ` <20131227021639.GD9184-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2014-01-09  9:41               ` Geert Uytterhoeven
     [not found]                 ` <CAMuHMdU+4qCc64CkJeLAhh4SHqbB0E8Cu=8dKpmaYbphTBJV6g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-10  0:49                   ` Simon Horman
2013-12-24  2:58 ` [PATCH 1/2] spi: rspi: Fix NULL pointer dereference on SH7757 Simon Horman
2013-12-24 13:12 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387823664-32318-1-git-send-email-geert+renesas@linux-m68k.org \
    --to=geert+renesas@linux-m68k.org \
    --cc=broonie@kernel.org \
    --cc=cm-hiep@jinso.co.jp \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).