From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-sh@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@linux-m68k.org>
Subject: [PATCH 2/2] spi: rspi: Fix typo when clearing SPSR_OVRF
Date: Mon, 23 Dec 2013 19:34:24 +0100 [thread overview]
Message-ID: <1387823664-32318-2-git-send-email-geert+renesas@linux-m68k.org> (raw)
In-Reply-To: <1387823664-32318-1-git-send-email-geert+renesas@linux-m68k.org>
The overrun flag should be cleared in the SPI Status Register, not in the
SPI Control Register, based on the SDK sample code.
Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
---
drivers/spi/spi-rspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-rspi.c b/drivers/spi/spi-rspi.c
index 9e0301014f48..b04835d809f5 100644
--- a/drivers/spi/spi-rspi.c
+++ b/drivers/spi/spi-rspi.c
@@ -517,7 +517,7 @@ static void rspi_receive_init(struct rspi_data *rspi)
rspi_read16(rspi, RSPI_SPDR); /* dummy read */
if (spsr & SPSR_OVRF)
rspi_write8(rspi, rspi_read8(rspi, RSPI_SPSR) & ~SPSR_OVRF,
- RSPI_SPCR);
+ RSPI_SPSR);
}
static int rspi_receive_pio(struct rspi_data *rspi, struct spi_message *mesg,
--
1.7.9.5
next prev parent reply other threads:[~2013-12-23 18:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 18:34 [PATCH 1/2] spi: rspi: Fix NULL pointer dereference on SH7757 Geert Uytterhoeven
2013-12-23 18:34 ` Geert Uytterhoeven [this message]
[not found] ` <1387823664-32318-2-git-send-email-geert+renesas-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2013-12-24 2:59 ` [PATCH 2/2] spi: rspi: Fix typo when clearing SPSR_OVRF Simon Horman
2013-12-24 9:26 ` Geert Uytterhoeven
[not found] ` <CAMuHMdWiJPF2NU+ME=CLMygvABZ_fcTyr7ggdQtFKbOGhCA0+w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-27 2:16 ` Simon Horman
[not found] ` <20131227021639.GD9184-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2014-01-09 9:41 ` Geert Uytterhoeven
[not found] ` <CAMuHMdU+4qCc64CkJeLAhh4SHqbB0E8Cu=8dKpmaYbphTBJV6g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-10 0:49 ` Simon Horman
2013-12-24 2:58 ` [PATCH 1/2] spi: rspi: Fix NULL pointer dereference on SH7757 Simon Horman
2013-12-24 13:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387823664-32318-2-git-send-email-geert+renesas@linux-m68k.org \
--to=geert+renesas@linux-m68k.org \
--cc=broonie@kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).