* [PATCH v5 01/11] ARM: shmobile: r7s72100 clock: Add RSPI clocks
[not found] ` <1391527445-14881-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
@ 2014-02-04 15:23 ` Geert Uytterhoeven
2014-02-04 15:23 ` [PATCH v5 02/11] ARM: shmobile: genmai legacy: Add RSPI support Geert Uytterhoeven
` (4 subsequent siblings)
5 siblings, 0 replies; 17+ messages in thread
From: Geert Uytterhoeven @ 2014-02-04 15:23 UTC (permalink / raw)
To: Simon Horman, Magnus Damm
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven
From: Geert Uytterhoeven <geert+renesas-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Signed-off-by: Geert Uytterhoeven <geert+renesas-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
---
v5:
- Rebased on top of renesas-devel-v3.14-rc1-20140204
v4:
- The platform device basename was changed from "rspi" to "rspi-rz"
v3:
- No changes
v2:
- Correct platform device names ("rspi%u" -> "rspi.%u")
arch/arm/mach-shmobile/clock-r7s72100.c | 21 ++++++++++++++++++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-shmobile/clock-r7s72100.c b/arch/arm/mach-shmobile/clock-r7s72100.c
index dd8ce87596de..ffb0fff41375 100644
--- a/arch/arm/mach-shmobile/clock-r7s72100.c
+++ b/arch/arm/mach-shmobile/clock-r7s72100.c
@@ -22,12 +22,14 @@
#include <mach/common.h>
#include <mach/r7s72100.h>
-/* registers */
+/* Frequency Control Registers */
#define FRQCR 0xfcfe0010
#define FRQCR2 0xfcfe0014
+/* Standby Control Registers */
#define STBCR3 0xfcfe0420
#define STBCR4 0xfcfe0424
#define STBCR9 0xfcfe0438
+#define STBCR10 0xfcfe043c
#define PLL_RATE 30
@@ -145,11 +147,19 @@ struct clk div4_clks[DIV4_NR] = {
| CLK_ENABLE_ON_INIT),
};
-enum { MSTP97, MSTP96, MSTP95, MSTP94,
+enum {
+ MSTP107, MSTP106, MSTP105, MSTP104, MSTP103,
+ MSTP97, MSTP96, MSTP95, MSTP94,
MSTP47, MSTP46, MSTP45, MSTP44, MSTP43, MSTP42, MSTP41, MSTP40,
- MSTP33, MSTP_NR };
+ MSTP33, MSTP_NR
+};
static struct clk mstp_clks[MSTP_NR] = {
+ [MSTP107] = SH_CLK_MSTP8(&peripheral1_clk, STBCR10, 7, 0), /* RSPI0 */
+ [MSTP106] = SH_CLK_MSTP8(&peripheral1_clk, STBCR10, 6, 0), /* RSPI1 */
+ [MSTP105] = SH_CLK_MSTP8(&peripheral1_clk, STBCR10, 5, 0), /* RSPI2 */
+ [MSTP104] = SH_CLK_MSTP8(&peripheral1_clk, STBCR10, 4, 0), /* RSPI3 */
+ [MSTP103] = SH_CLK_MSTP8(&peripheral1_clk, STBCR10, 3, 0), /* RSPI4 */
[MSTP97] = SH_CLK_MSTP8(&peripheral0_clk, STBCR9, 7, 0), /* RIIC0 */
[MSTP96] = SH_CLK_MSTP8(&peripheral0_clk, STBCR9, 6, 0), /* RIIC1 */
[MSTP95] = SH_CLK_MSTP8(&peripheral0_clk, STBCR9, 5, 0), /* RIIC2 */
@@ -176,6 +186,11 @@ static struct clk_lookup lookups[] = {
CLKDEV_CON_ID("cpu_clk", &div4_clks[DIV4_I]),
/* MSTP clocks */
+ CLKDEV_DEV_ID("rspi-rz.0", &mstp_clks[MSTP107]),
+ CLKDEV_DEV_ID("rspi-rz.1", &mstp_clks[MSTP106]),
+ CLKDEV_DEV_ID("rspi-rz.2", &mstp_clks[MSTP105]),
+ CLKDEV_DEV_ID("rspi-rz.3", &mstp_clks[MSTP104]),
+ CLKDEV_DEV_ID("rspi-rz.4", &mstp_clks[MSTP103]),
CLKDEV_DEV_ID("fcfee000.i2c", &mstp_clks[MSTP97]),
CLKDEV_DEV_ID("fcfee400.i2c", &mstp_clks[MSTP96]),
CLKDEV_DEV_ID("fcfee800.i2c", &mstp_clks[MSTP95]),
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v5 02/11] ARM: shmobile: genmai legacy: Add RSPI support
[not found] ` <1391527445-14881-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2014-02-04 15:23 ` [PATCH v5 01/11] ARM: shmobile: r7s72100 clock: Add RSPI clocks Geert Uytterhoeven
@ 2014-02-04 15:23 ` Geert Uytterhoeven
2014-02-04 15:23 ` [PATCH v5 05/11] ARM: shmobile: r7s72100 dtsi: Add RSPI nodes Geert Uytterhoeven
` (3 subsequent siblings)
5 siblings, 0 replies; 17+ messages in thread
From: Geert Uytterhoeven @ 2014-02-04 15:23 UTC (permalink / raw)
To: Simon Horman, Magnus Damm
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven
From: Geert Uytterhoeven <geert+renesas-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Add RSPI platform device, resources, platform data, and SPI child.
On this board, only rspi4 is in use. Its bus contains a single device
(a wm8978 audio codec).
Signed-off-by: Geert Uytterhoeven <geert+renesas-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
---
v5:
- Rebased on top of renesas-devel-v3.14-rc1-20140204
v4:
- The platform device basename was changed from "rspi" to "rspi-rz",
dropping the platform data flags in the process
- Switch to named IRQs
v3:
- Move platform devices from setup-r7s72100.c to board-genmai.c, as
genmai-reference will use devices instantiated from DT
- Merge with "ARM: shmobile: genmai: Add RSPI children", as this now
touches the same file
- Instantiate SPI children in C on genmai only, as genmai-reference will
instantiate them from DT
v2:
- Correct platform device names ("rspi%u.0" -> "rspi.%u")
- Add missing platform data
- Correct summary (resources -> platform devices)
arch/arm/mach-shmobile/board-genmai.c | 44 +++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/arch/arm/mach-shmobile/board-genmai.c b/arch/arm/mach-shmobile/board-genmai.c
index 3e92e3c62d4c..c4064610e223 100644
--- a/arch/arm/mach-shmobile/board-genmai.c
+++ b/arch/arm/mach-shmobile/board-genmai.c
@@ -20,15 +20,59 @@
#include <linux/kernel.h>
#include <linux/platform_device.h>
+#include <linux/spi/rspi.h>
+#include <linux/spi/spi.h>
#include <mach/common.h>
+#include <mach/irqs.h>
#include <mach/r7s72100.h>
#include <asm/mach-types.h>
#include <asm/mach/arch.h>
+/* RSPI */
+#define RSPI_RESOURCE(idx, baseaddr, irq) \
+static const struct resource rspi##idx##_resources[] __initconst = { \
+ DEFINE_RES_MEM(baseaddr, 0x24), \
+ DEFINE_RES_IRQ_NAMED(irq, "error"), \
+ DEFINE_RES_IRQ_NAMED(irq + 1, "rx"), \
+ DEFINE_RES_IRQ_NAMED(irq + 2, "tx"), \
+}
+
+RSPI_RESOURCE(0, 0xe800c800, gic_iid(270));
+RSPI_RESOURCE(1, 0xe800d000, gic_iid(273));
+RSPI_RESOURCE(2, 0xe800d800, gic_iid(276));
+RSPI_RESOURCE(3, 0xe800e000, gic_iid(279));
+RSPI_RESOURCE(4, 0xe800e800, gic_iid(282));
+
+static const struct rspi_plat_data rspi_pdata __initconst = {
+ .num_chipselect = 1,
+};
+
+#define r7s72100_register_rspi(idx) \
+ platform_device_register_resndata(&platform_bus, "rspi-rz", idx, \
+ rspi##idx##_resources, \
+ ARRAY_SIZE(rspi##idx##_resources), \
+ &rspi_pdata, sizeof(rspi_pdata))
+
+static const struct spi_board_info spi_info[] __initconst = {
+ {
+ .modalias = "wm8978",
+ .max_speed_hz = 5000000,
+ .bus_num = 4,
+ .chip_select = 0,
+ },
+};
+
static void __init genmai_add_standard_devices(void)
{
r7s72100_clock_init();
r7s72100_add_dt_devices();
+
+ r7s72100_register_rspi(0);
+ r7s72100_register_rspi(1);
+ r7s72100_register_rspi(2);
+ r7s72100_register_rspi(3);
+ r7s72100_register_rspi(4);
+ spi_register_board_info(spi_info, ARRAY_SIZE(spi_info));
}
static const char * const genmai_boards_compat_dt[] __initconst = {
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v5 05/11] ARM: shmobile: r7s72100 dtsi: Add RSPI nodes
[not found] ` <1391527445-14881-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2014-02-04 15:23 ` [PATCH v5 01/11] ARM: shmobile: r7s72100 clock: Add RSPI clocks Geert Uytterhoeven
2014-02-04 15:23 ` [PATCH v5 02/11] ARM: shmobile: genmai legacy: Add RSPI support Geert Uytterhoeven
@ 2014-02-04 15:23 ` Geert Uytterhoeven
2014-02-04 15:24 ` [PATCH v4 07/11] ARM: shmobile: koelsch legacy: Add QSPI support Geert Uytterhoeven
` (2 subsequent siblings)
5 siblings, 0 replies; 17+ messages in thread
From: Geert Uytterhoeven @ 2014-02-04 15:23 UTC (permalink / raw)
To: Simon Horman, Magnus Damm
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven,
devicetree-u79uwXL29TY76Z2rM5mHXA
From: Geert Uytterhoeven <geert+renesas-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Signed-off-by: Geert Uytterhoeven <geert+renesas-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
v5:
- Rebased on top of renesas-devel-v3.14-rc1-20140204
v4:
- Switch to named IRQs
v3:
- No changes
v2:
- No changes
arch/arm/boot/dts/r7s72100-genmai-reference.dts | 2 +-
arch/arm/boot/dts/r7s72100.dtsi | 75 +++++++++++++++++++++++
2 files changed, 76 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/r7s72100-genmai-reference.dts b/arch/arm/boot/dts/r7s72100-genmai-reference.dts
index da19c70ed82b..0849017e9d2f 100644
--- a/arch/arm/boot/dts/r7s72100-genmai-reference.dts
+++ b/arch/arm/boot/dts/r7s72100-genmai-reference.dts
@@ -9,7 +9,7 @@
*/
/dts-v1/;
-/include/ "r7s72100.dtsi"
+#include "r7s72100.dtsi"
/ {
model = "Genmai";
diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index 46b82aa7dc4e..9be67a16fc6f 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -8,12 +8,22 @@
* kind, whether express or implied.
*/
+#include <dt-bindings/interrupt-controller/irq.h>
+
/ {
compatible = "renesas,r7s72100";
interrupt-parent = <&gic>;
#address-cells = <1>;
#size-cells = <1>;
+ aliases {
+ spi0 = &spi0;
+ spi1 = &spi1;
+ spi2 = &spi2;
+ spi3 = &spi3;
+ spi4 = &spi4;
+ };
+
cpus {
#address-cells = <1>;
#size-cells = <0>;
@@ -33,4 +43,69 @@
reg = <0xe8201000 0x1000>,
<0xe8202000 0x1000>;
};
+
+ spi0: spi@e800c800 {
+ compatible = "renesas,rspi-r7s72100", "renesas,rspi-rz";
+ reg = <0xe800c800 0x24>;
+ interrupts = <0 238 IRQ_TYPE_LEVEL_HIGH>,
+ <0 239 IRQ_TYPE_LEVEL_HIGH>,
+ <0 240 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "error", "rx", "tx";
+ num-cs = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
+ spi1: spi@e800d000 {
+ compatible = "renesas,rspi-r7s72100", "renesas,rspi-rz";
+ reg = <0xe800d000 0x24>;
+ interrupts = <0 241 IRQ_TYPE_LEVEL_HIGH>,
+ <0 242 IRQ_TYPE_LEVEL_HIGH>,
+ <0 243 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "error", "rx", "tx";
+ num-cs = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
+ spi2: spi@e800d800 {
+ compatible = "renesas,rspi-r7s72100", "renesas,rspi-rz";
+ reg = <0xe800d800 0x24>;
+ interrupts = <0 244 IRQ_TYPE_LEVEL_HIGH>,
+ <0 245 IRQ_TYPE_LEVEL_HIGH>,
+ <0 246 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "error", "rx", "tx";
+ num-cs = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
+ spi3: spi@e800e000 {
+ compatible = "renesas,rspi-r7s72100", "renesas,rspi-rz";
+ reg = <0xe800e000 0x24>;
+ interrupts = <0 247 IRQ_TYPE_LEVEL_HIGH>,
+ <0 248 IRQ_TYPE_LEVEL_HIGH>,
+ <0 249 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "error", "rx", "tx";
+ num-cs = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
+ spi4: spi@e800e800 {
+ compatible = "renesas,rspi-r7s72100", "renesas,rspi-rz";
+ reg = <0xe800e800 0x24>;
+ interrupts = <0 250 IRQ_TYPE_LEVEL_HIGH>,
+ <0 251 IRQ_TYPE_LEVEL_HIGH>,
+ <0 252 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "error", "rx", "tx";
+ num-cs = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
};
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v4 07/11] ARM: shmobile: koelsch legacy: Add QSPI support
[not found] ` <1391527445-14881-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
` (2 preceding siblings ...)
2014-02-04 15:23 ` [PATCH v5 05/11] ARM: shmobile: r7s72100 dtsi: Add RSPI nodes Geert Uytterhoeven
@ 2014-02-04 15:24 ` Geert Uytterhoeven
2014-02-04 17:37 ` [PATCH 00/11] ARM: shmobile: RSPI RZ and QSPI SoC and board integration Mark Brown
2014-02-05 0:56 ` Simon Horman
5 siblings, 0 replies; 17+ messages in thread
From: Geert Uytterhoeven @ 2014-02-04 15:24 UTC (permalink / raw)
To: Simon Horman, Magnus Damm
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven
From: Geert Uytterhoeven <geert+renesas-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Enable support for the Spansion s25fl512s SPI FLASH on the Koelsch board:
- Add QSPI platform device, resources, platform data, and pinmux,
- Add FLASH data and MTD partitions.
Signed-off-by: Geert Uytterhoeven <geert+renesas-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Acked-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
---
v4:
- Rebased on top of renesas-devel-v3.14-rc1-20140204
v3:
- Switch to named IRQs
v2:
- Split in 2 groups (qspi_ctrl/qspi_data4)
arch/arm/mach-shmobile/board-koelsch.c | 64 ++++++++++++++++++++++++++++++++
1 file changed, 64 insertions(+)
diff --git a/arch/arm/mach-shmobile/board-koelsch.c b/arch/arm/mach-shmobile/board-koelsch.c
index 2ab5c75ba2c2..56020d9fa841 100644
--- a/arch/arm/mach-shmobile/board-koelsch.c
+++ b/arch/arm/mach-shmobile/board-koelsch.c
@@ -25,12 +25,17 @@
#include <linux/input.h>
#include <linux/kernel.h>
#include <linux/leds.h>
+#include <linux/mtd/mtd.h>
+#include <linux/mtd/partitions.h>
#include <linux/phy.h>
#include <linux/pinctrl/machine.h>
#include <linux/platform_data/gpio-rcar.h>
#include <linux/platform_data/rcar-du.h>
#include <linux/platform_device.h>
#include <linux/sh_eth.h>
+#include <linux/spi/flash.h>
+#include <linux/spi/rspi.h>
+#include <linux/spi/spi.h>
#include <mach/common.h>
#include <mach/irqs.h>
#include <mach/r8a7791.h>
@@ -148,6 +153,55 @@ static const struct gpio_keys_platform_data koelsch_keys_pdata __initconst = {
.nbuttons = ARRAY_SIZE(gpio_buttons),
};
+/* QSPI */
+static const struct resource qspi_resources[] __initconst = {
+ DEFINE_RES_MEM(0xe6b10000, 0x1000),
+ DEFINE_RES_IRQ_NAMED(gic_spi(184), "mux"),
+};
+
+static const struct rspi_plat_data qspi_pdata __initconst = {
+ .num_chipselect = 1,
+};
+
+/* SPI Flash memory (Spansion S25FL512SAGMFIG11 64 MiB) */
+static struct mtd_partition spi_flash_part[] = {
+ {
+ .name = "loader",
+ .offset = 0x00000000,
+ .size = 512 * 1024,
+ .mask_flags = MTD_WRITEABLE,
+ },
+ {
+ .name = "bootenv",
+ .offset = MTDPART_OFS_APPEND,
+ .size = 512 * 1024,
+ .mask_flags = MTD_WRITEABLE,
+ },
+ {
+ .name = "data",
+ .offset = MTDPART_OFS_APPEND,
+ .size = MTDPART_SIZ_FULL,
+ },
+};
+
+static const struct flash_platform_data spi_flash_data = {
+ .name = "m25p80",
+ .parts = spi_flash_part,
+ .nr_parts = ARRAY_SIZE(spi_flash_part),
+ .type = "s25fl512s",
+};
+
+static const struct spi_board_info spi_info[] __initconst = {
+ {
+ .modalias = "m25p80",
+ .platform_data = &spi_flash_data,
+ .mode = SPI_MODE_0,
+ .max_speed_hz = 30000000,
+ .bus_num = 0,
+ .chip_select = 0,
+ },
+};
+
/* SATA0 */
static const struct resource sata0_resources[] __initconst = {
DEFINE_RES_MEM(0xee300000, 0x2000),
@@ -180,6 +234,11 @@ static const struct pinctrl_map koelsch_pinctrl_map[] = {
"eth_rmii", "eth"),
PIN_MAP_MUX_GROUP_DEFAULT("r8a7791-ether", "pfc-r8a7791",
"intc_irq0", "intc"),
+ /* QSPI */
+ PIN_MAP_MUX_GROUP_DEFAULT("qspi.0", "pfc-r8a7791",
+ "qspi_ctrl", "qspi"),
+ PIN_MAP_MUX_GROUP_DEFAULT("qspi.0", "pfc-r8a7791",
+ "qspi_data4", "qspi"),
/* SCIF0 (CN19: DEBUG SERIAL0) */
PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.6", "pfc-r8a7791",
"scif0_data_d", "scif0"),
@@ -205,6 +264,11 @@ static void __init koelsch_add_standard_devices(void)
platform_device_register_data(&platform_bus, "gpio-keys", -1,
&koelsch_keys_pdata,
sizeof(koelsch_keys_pdata));
+ platform_device_register_resndata(&platform_bus, "qspi", 0,
+ qspi_resources,
+ ARRAY_SIZE(qspi_resources),
+ &qspi_pdata, sizeof(qspi_pdata));
+ spi_register_board_info(spi_info, ARRAY_SIZE(spi_info));
koelsch_add_du_device();
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 00/11] ARM: shmobile: RSPI RZ and QSPI SoC and board integration
[not found] ` <1391527445-14881-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
` (3 preceding siblings ...)
2014-02-04 15:24 ` [PATCH v4 07/11] ARM: shmobile: koelsch legacy: Add QSPI support Geert Uytterhoeven
@ 2014-02-04 17:37 ` Mark Brown
[not found] ` <20140204173733.GI22609-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-02-05 0:56 ` Simon Horman
5 siblings, 1 reply; 17+ messages in thread
From: Mark Brown @ 2014-02-04 17:37 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Simon Horman, Magnus Damm, linux-spi-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
On Tue, Feb 04, 2014 at 04:23:54PM +0100, Geert Uytterhoeven wrote:
> Hi Simon, Magnus,
>
> This patch series contains SoC and board integration for
> 1. RSPI in the r7s72100 aka RZ/A1H SoC on the Genmai reference board,
> 2. QSPI in the r8a7791 aka R-Car M2 SoC on the Koelsch reference board.
> It was rebased on top of renesas-devel-v3.14-rc1-20140204.
Can you please stop CCing arch/arm only patch serieses like this to the
SPI list - they just mean I have to go through patchwork and mark them
as not applicable.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 00/11] ARM: shmobile: RSPI RZ and QSPI SoC and board integration
[not found] ` <1391527445-14881-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
` (4 preceding siblings ...)
2014-02-04 17:37 ` [PATCH 00/11] ARM: shmobile: RSPI RZ and QSPI SoC and board integration Mark Brown
@ 2014-02-05 0:56 ` Simon Horman
2014-02-06 10:36 ` Magnus Damm
5 siblings, 1 reply; 17+ messages in thread
From: Simon Horman @ 2014-02-05 0:56 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Magnus Damm, linux-spi-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Magnus, could you Ack these or otherwise?
On Tue, Feb 04, 2014 at 04:23:54PM +0100, Geert Uytterhoeven wrote:
> Hi Simon, Magnus,
>
> This patch series contains SoC and board integration for
> 1. RSPI in the r7s72100 aka RZ/A1H SoC on the Genmai reference board,
> 2. QSPI in the r8a7791 aka R-Car M2 SoC on the Koelsch reference board.
> It was rebased on top of renesas-devel-v3.14-rc1-20140204.
>
> It was tested on the r7s72100-based Genmai reference board using loopback
> mode, and on the r8a7791-based Koelsch reference board using the Spansion
> s25fl512s SPI FLASH.
>
> - [v5 01/11] ARM: shmobile: r7s72100 clock: Add RSPI clocks
> - [v5 02/11] ARM: shmobile: genmai legacy: Add RSPI support
> - [v3 03/11] ARM: shmobile: genmai defconfig: Enable RSPI
> - [v3 04/11] ARM: shmobile: r7s72100 clock: Add RSPI clocks for DT
> - [v5 05/11] ARM: shmobile: r7s72100 dtsi: Add RSPI nodes
> - [v4 06/11] ARM: shmobile: r8a7791 clock: add QSPI clocks
> - [v4 07/11] ARM: shmobile: koelsch legacy: Add QSPI support
> - [v4 08/11] ARM: shmobile: koelsch defconfig: Enable RSPI and
> - [v3 09/11] ARM: shmobile: r8a7791 dtsi: Add QSPI node
> - [v3 10/11] ARM: shmobile: koelsch dts: Add QSPI nodes
> - [v2 11/11] ARM: shmobile: lager legacy: Switch QSPI to named IRQs
Above I see v2, v3, v4 and v5 patches.
While I can make sense of this it makes it cumbersome to refer to the
series as a whole.
Bob, can you take a look at '"[PATCH 00/11] ARM: shmobile: RSPI RZ and
QSPI SoC and board", posted on Tuesday the 2nd, which includes v2, v3,
v4 and v5 patches'?
What would make my life easier would be if the entire series was v5 and
all the patches contained in it were v5. Then I could just ask Bob to look
at "[PATCH v5 00/11] ARM: shmobile: RSPI RZ and QSPI SoC and board"
There is no Bob but I do ask people these kind of questions :)
> All of these should be safe to apply, without compile-time or run-time
> dependencies on other parts.
> Actual functioning for some parts may depend on RSPI work queued up for
> 3.15 in the spi tree.
>
> Compared to previous submission, the following have been postponed:
> - [v4 03/15] [WIP] ARM: shmobile: genmai legacy: Add preliminary RSPI
> pinmux setup
> This depends on the to-be-written non-DT pinmux configuration for
> r7s72100.
> - [v4 07/15] ARM: shmobile: genmai reference dts: Add RSPI nodes
> This depends on Magnus' "ARM: shmobile: r7s72100 GPIO and PINCTRL device
> nodes"
> - [v1 14/15] ARM: shmobile: koelsch legacy: Enable Quad SPI transfers for
> the SPI FLASH
> - [v1 15/15] ARM: shmobile: koelsch dts: Enable Quad SPI transfers
> These two depend on the RSPI Dual/Quad work queued up in the spi tree.
> After applying the r8a7791/Koelsch patches above, the mainline RSPI/QSPI
> driver will work fine. But enabling Quad SPI transfers in board support
> code or DT without the corresponding support in the RSPI driver would
> cause a regression.
>
> Please apply this series, Thanks!
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 00/11] ARM: shmobile: RSPI RZ and QSPI SoC and board integration
2014-02-05 0:56 ` Simon Horman
@ 2014-02-06 10:36 ` Magnus Damm
2014-02-06 11:43 ` Simon Horman
0 siblings, 1 reply; 17+ messages in thread
From: Magnus Damm @ 2014-02-06 10:36 UTC (permalink / raw)
To: Simon Horman
Cc: Geert Uytterhoeven, linux-spi, SH-Linux,
linux-arm-kernel@lists.infradead.org, linux-kernel
On Wed, Feb 5, 2014 at 9:56 AM, Simon Horman <horms@verge.net.au> wrote:
> Magnus, could you Ack these or otherwise?
>
> On Tue, Feb 04, 2014 at 04:23:54PM +0100, Geert Uytterhoeven wrote:
>> Hi Simon, Magnus,
>>
>> This patch series contains SoC and board integration for
>> 1. RSPI in the r7s72100 aka RZ/A1H SoC on the Genmai reference board,
>> 2. QSPI in the r8a7791 aka R-Car M2 SoC on the Koelsch reference board.
>> It was rebased on top of renesas-devel-v3.14-rc1-20140204.
>>
>> It was tested on the r7s72100-based Genmai reference board using loopback
>> mode, and on the r8a7791-based Koelsch reference board using the Spansion
>> s25fl512s SPI FLASH.
>>
>> - [v5 01/11] ARM: shmobile: r7s72100 clock: Add RSPI clocks
>> - [v5 02/11] ARM: shmobile: genmai legacy: Add RSPI support
>> - [v3 03/11] ARM: shmobile: genmai defconfig: Enable RSPI
>> - [v3 04/11] ARM: shmobile: r7s72100 clock: Add RSPI clocks for DT
>> - [v5 05/11] ARM: shmobile: r7s72100 dtsi: Add RSPI nodes
>> - [v4 06/11] ARM: shmobile: r8a7791 clock: add QSPI clocks
>> - [v4 07/11] ARM: shmobile: koelsch legacy: Add QSPI support
>> - [v4 08/11] ARM: shmobile: koelsch defconfig: Enable RSPI and
>> - [v3 09/11] ARM: shmobile: r8a7791 dtsi: Add QSPI node
>> - [v3 10/11] ARM: shmobile: koelsch dts: Add QSPI nodes
>> - [v2 11/11] ARM: shmobile: lager legacy: Switch QSPI to named IRQs
>
> Above I see v2, v3, v4 and v5 patches.
>
> While I can make sense of this it makes it cumbersome to refer to the
> series as a whole.
>
> Bob, can you take a look at '"[PATCH 00/11] ARM: shmobile: RSPI RZ and
> QSPI SoC and board", posted on Tuesday the 2nd, which includes v2, v3,
> v4 and v5 patches'?
>
> What would make my life easier would be if the entire series was v5 and
> all the patches contained in it were v5. Then I could just ask Bob to look
> at "[PATCH v5 00/11] ARM: shmobile: RSPI RZ and QSPI SoC and board"
>
> There is no Bob but I do ask people these kind of questions :)
Simon, Geert, Bob,
I've now gone through these patches and I think they look great. My
apologies for slow handling.
Acked-by: Magnus Damm <damm@opensource.se>
Thanks for your help.
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 00/11] ARM: shmobile: RSPI RZ and QSPI SoC and board integration
2014-02-06 10:36 ` Magnus Damm
@ 2014-02-06 11:43 ` Simon Horman
0 siblings, 0 replies; 17+ messages in thread
From: Simon Horman @ 2014-02-06 11:43 UTC (permalink / raw)
To: Magnus Damm
Cc: Geert Uytterhoeven, linux-spi, SH-Linux,
linux-arm-kernel@lists.infradead.org, linux-kernel
On Thu, Feb 06, 2014 at 07:36:17PM +0900, Magnus Damm wrote:
> On Wed, Feb 5, 2014 at 9:56 AM, Simon Horman <horms@verge.net.au> wrote:
> > Magnus, could you Ack these or otherwise?
> >
> > On Tue, Feb 04, 2014 at 04:23:54PM +0100, Geert Uytterhoeven wrote:
> >> Hi Simon, Magnus,
> >>
> >> This patch series contains SoC and board integration for
> >> 1. RSPI in the r7s72100 aka RZ/A1H SoC on the Genmai reference board,
> >> 2. QSPI in the r8a7791 aka R-Car M2 SoC on the Koelsch reference board.
> >> It was rebased on top of renesas-devel-v3.14-rc1-20140204.
> >>
> >> It was tested on the r7s72100-based Genmai reference board using loopback
> >> mode, and on the r8a7791-based Koelsch reference board using the Spansion
> >> s25fl512s SPI FLASH.
> >>
> >> - [v5 01/11] ARM: shmobile: r7s72100 clock: Add RSPI clocks
> >> - [v5 02/11] ARM: shmobile: genmai legacy: Add RSPI support
> >> - [v3 03/11] ARM: shmobile: genmai defconfig: Enable RSPI
> >> - [v3 04/11] ARM: shmobile: r7s72100 clock: Add RSPI clocks for DT
> >> - [v5 05/11] ARM: shmobile: r7s72100 dtsi: Add RSPI nodes
> >> - [v4 06/11] ARM: shmobile: r8a7791 clock: add QSPI clocks
> >> - [v4 07/11] ARM: shmobile: koelsch legacy: Add QSPI support
> >> - [v4 08/11] ARM: shmobile: koelsch defconfig: Enable RSPI and
> >> - [v3 09/11] ARM: shmobile: r8a7791 dtsi: Add QSPI node
> >> - [v3 10/11] ARM: shmobile: koelsch dts: Add QSPI nodes
> >> - [v2 11/11] ARM: shmobile: lager legacy: Switch QSPI to named IRQs
> >
> > Above I see v2, v3, v4 and v5 patches.
> >
> > While I can make sense of this it makes it cumbersome to refer to the
> > series as a whole.
> >
> > Bob, can you take a look at '"[PATCH 00/11] ARM: shmobile: RSPI RZ and
> > QSPI SoC and board", posted on Tuesday the 2nd, which includes v2, v3,
> > v4 and v5 patches'?
> >
> > What would make my life easier would be if the entire series was v5 and
> > all the patches contained in it were v5. Then I could just ask Bob to look
> > at "[PATCH v5 00/11] ARM: shmobile: RSPI RZ and QSPI SoC and board"
> >
> > There is no Bob but I do ask people these kind of questions :)
>
> Simon, Geert, Bob,
>
> I've now gone through these patches and I think they look great. My
> apologies for slow handling.
>
> Acked-by: Magnus Damm <damm@opensource.se>
Thanks, I have queued these up.
^ permalink raw reply [flat|nested] 17+ messages in thread