* [PATCH 1/2] spi: spi-mxs: Propagate the real error code on platform_get_irq() failure
@ 2014-02-14 3:19 Fabio Estevam
[not found] ` <1392347962-9835-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2014-02-14 3:19 UTC (permalink / raw)
To: broonie-DgEjT+Ai2ygdnm+yROfE0A
Cc: marex-ynQEQJNshbs, linux-spi-u79uwXL29TY76Z2rM5mHXA,
Fabio Estevam
From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
No need to return a 'fake' return value on platform_get_irq() failure.
Just return the error code itself instead.
Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
drivers/spi/spi-mxs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
index 4208f24..2884f0c 100644
--- a/drivers/spi/spi-mxs.c
+++ b/drivers/spi/spi-mxs.c
@@ -472,7 +472,7 @@ static int mxs_spi_probe(struct platform_device *pdev)
iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
irq_err = platform_get_irq(pdev, 0);
if (irq_err < 0)
- return -EINVAL;
+ return irq_err;
base = devm_ioremap_resource(&pdev->dev, iores);
if (IS_ERR(base))
--
1.8.1.2
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread[parent not found: <1392347962-9835-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* [PATCH 2/2] spi: spi-imx: Propagate the real error code on platform_get_irq() failure [not found] ` <1392347962-9835-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2014-02-14 3:19 ` Fabio Estevam [not found] ` <1392347962-9835-2-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2014-02-14 8:22 ` [PATCH 1/2] spi: spi-mxs: " Marek Vasut 2014-02-14 20:40 ` Mark Brown 2 siblings, 1 reply; 6+ messages in thread From: Fabio Estevam @ 2014-02-14 3:19 UTC (permalink / raw) To: broonie-DgEjT+Ai2ygdnm+yROfE0A Cc: marex-ynQEQJNshbs, linux-spi-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org> No need to return a 'fake' return value on platform_get_irq() failure. Just return the error code itself instead. Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org> --- drivers/spi/spi-imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 2ccfde6..3577939 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -879,7 +879,7 @@ static int spi_imx_probe(struct platform_device *pdev) spi_imx->irq = platform_get_irq(pdev, 0); if (spi_imx->irq < 0) { - ret = -EINVAL; + ret = spi_imx->irq; goto out_master_put; } -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <1392347962-9835-2-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 2/2] spi: spi-imx: Propagate the real error code on platform_get_irq() failure [not found] ` <1392347962-9835-2-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2014-02-14 8:22 ` Marek Vasut 2014-02-14 20:41 ` Mark Brown 1 sibling, 0 replies; 6+ messages in thread From: Marek Vasut @ 2014-02-14 8:22 UTC (permalink / raw) To: Fabio Estevam Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A, linux-spi-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam On Friday, February 14, 2014 at 04:19:22 AM, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org> > > No need to return a 'fake' return value on platform_get_irq() failure. > > Just return the error code itself instead. > > Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org> Acked-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org> Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] spi: spi-imx: Propagate the real error code on platform_get_irq() failure [not found] ` <1392347962-9835-2-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2014-02-14 8:22 ` Marek Vasut @ 2014-02-14 20:41 ` Mark Brown 1 sibling, 0 replies; 6+ messages in thread From: Mark Brown @ 2014-02-14 20:41 UTC (permalink / raw) To: Fabio Estevam Cc: marex-ynQEQJNshbs, linux-spi-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam [-- Attachment #1: Type: text/plain, Size: 291 bytes --] On Fri, Feb 14, 2014 at 01:19:22AM -0200, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org> > > No need to return a 'fake' return value on platform_get_irq() failure. > > Just return the error code itself instead. Applied, thanks. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] spi: spi-mxs: Propagate the real error code on platform_get_irq() failure [not found] ` <1392347962-9835-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2014-02-14 3:19 ` [PATCH 2/2] spi: spi-imx: " Fabio Estevam @ 2014-02-14 8:22 ` Marek Vasut 2014-02-14 20:40 ` Mark Brown 2 siblings, 0 replies; 6+ messages in thread From: Marek Vasut @ 2014-02-14 8:22 UTC (permalink / raw) To: Fabio Estevam Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A, linux-spi-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam On Friday, February 14, 2014 at 04:19:21 AM, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org> > > No need to return a 'fake' return value on platform_get_irq() failure. > > Just return the error code itself instead. > > Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org> Acked-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org> Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] spi: spi-mxs: Propagate the real error code on platform_get_irq() failure [not found] ` <1392347962-9835-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2014-02-14 3:19 ` [PATCH 2/2] spi: spi-imx: " Fabio Estevam 2014-02-14 8:22 ` [PATCH 1/2] spi: spi-mxs: " Marek Vasut @ 2014-02-14 20:40 ` Mark Brown 2 siblings, 0 replies; 6+ messages in thread From: Mark Brown @ 2014-02-14 20:40 UTC (permalink / raw) To: Fabio Estevam Cc: marex-ynQEQJNshbs, linux-spi-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam [-- Attachment #1: Type: text/plain, Size: 291 bytes --] On Fri, Feb 14, 2014 at 01:19:21AM -0200, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org> > > No need to return a 'fake' return value on platform_get_irq() failure. > > Just return the error code itself instead. Applied, thanks. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-14 20:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-14 3:19 [PATCH 1/2] spi: spi-mxs: Propagate the real error code on platform_get_irq() failure Fabio Estevam
[not found] ` <1392347962-9835-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-14 3:19 ` [PATCH 2/2] spi: spi-imx: " Fabio Estevam
[not found] ` <1392347962-9835-2-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-14 8:22 ` Marek Vasut
2014-02-14 20:41 ` Mark Brown
2014-02-14 8:22 ` [PATCH 1/2] spi: spi-mxs: " Marek Vasut
2014-02-14 20:40 ` Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).