* [PATCH] spi: oc-tiny: Remove unneeded NULL checking for hw->bitbang.master
@ 2014-03-05 5:34 Axel Lin
2014-03-13 9:54 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2014-03-05 5:34 UTC (permalink / raw)
To: Mark Brown; +Cc: Thomas Chou, linux-spi-u79uwXL29TY76Z2rM5mHXA
We already has NULL test for master after calling spi_alloc_master().
Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
---
drivers/spi/spi-oc-tiny.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/spi/spi-oc-tiny.c b/drivers/spi/spi-oc-tiny.c
index 022774e..8998d11 100644
--- a/drivers/spi/spi-oc-tiny.c
+++ b/drivers/spi/spi-oc-tiny.c
@@ -266,8 +266,6 @@ static int tiny_spi_probe(struct platform_device *pdev)
/* setup the state for the bitbang driver */
hw->bitbang.master = master;
- if (!hw->bitbang.master)
- return err;
hw->bitbang.setup_transfer = tiny_spi_setup_transfer;
hw->bitbang.chipselect = tiny_spi_chipselect;
hw->bitbang.txrx_bufs = tiny_spi_txrx_bufs;
--
1.8.1.2
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] spi: oc-tiny: Remove unneeded NULL checking for hw->bitbang.master
2014-03-05 5:34 [PATCH] spi: oc-tiny: Remove unneeded NULL checking for hw->bitbang.master Axel Lin
@ 2014-03-13 9:54 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-03-13 9:54 UTC (permalink / raw)
To: Axel Lin; +Cc: Thomas Chou, linux-spi-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 148 bytes --]
On Wed, Mar 05, 2014 at 01:34:21PM +0800, Axel Lin wrote:
> We already has NULL test for master after calling spi_alloc_master().
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-13 9:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-05 5:34 [PATCH] spi: oc-tiny: Remove unneeded NULL checking for hw->bitbang.master Axel Lin
2014-03-13 9:54 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).