Linux SPI subsystem development
 help / color / mirror / Atom feed
From: Sourav Poddar <sourav.poddar-l0cyMroinI0@public.gmane.org>
To: <broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Sourav Poddar <sourav.poddar-l0cyMroinI0@public.gmane.org>
Subject: [PATCH] spi/qspi: Fix return from mmap path
Date: Mon, 10 Mar 2014 14:59:13 +0530	[thread overview]
Message-ID: <1394443753-25773-1-git-send-email-sourav.poddar@ti.com> (raw)

mmap resource requirement is only for memory mapped operations.
If the user does not populate mmap resource, dont call return,
instead we go on for normal spi mode operations.

Signed-off-by: Sourav Poddar <sourav.poddar-l0cyMroinI0@public.gmane.org>
---
 drivers/spi/spi-ti-qspi.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
index 49ddfc7..6c211d1 100644
--- a/drivers/spi/spi-ti-qspi.c
+++ b/drivers/spi/spi-ti-qspi.c
@@ -461,7 +461,6 @@ static int ti_qspi_probe(struct platform_device *pdev)
 		if (res_mmap == NULL) {
 			dev_err(&pdev->dev,
 				"memory mapped resource not required\n");
-			return -ENODEV;
 		}
 	}
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2014-03-10  9:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10  9:29 Sourav Poddar [this message]
     [not found] ` <1394443753-25773-1-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2014-03-10  9:49   ` [PATCH] spi/qspi: Fix return from mmap path sourav
     [not found]     ` <531D8AA1.305-l0cyMroinI0@public.gmane.org>
2014-03-10 10:15       ` Mark Brown
     [not found]         ` <20140310101556.GR28112-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-03-10 10:20           ` sourav
     [not found]             ` <531D91FA.3070408-l0cyMroinI0@public.gmane.org>
2014-03-10 10:28               ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2014-03-10 10:30 Sourav Poddar
     [not found] ` <1394447443-9861-1-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2014-03-10 11:12   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394443753-25773-1-git-send-email-sourav.poddar@ti.com \
    --to=sourav.poddar-l0cymroini0@public.gmane.org \
    --cc=broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox