From: "Alexander Shiyan" <shc_work-JGs/UdohzUI@public.gmane.org>
To: "Axel Lin" <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Mark Brown" <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] spi: clps711x: Enable driver compilation with COMPILE_TEST
Date: Wed, 26 Mar 2014 12:31:06 +0400 [thread overview]
Message-ID: <1395822666.112180924@f305.i.mail.ru> (raw)
In-Reply-To: <1395822170.7555.0.camel@phoenix>
Wed, 26 Mar 2014 16:22:50 +0800 от Axel Lin <axel.lin@ingics.com>:
> This helps increasing build testing coverage.
> This driver uses SYSCON APIs, so it needs to depend on MFD_SYSCON.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/spi/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 1ee6a54..78ca395 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -150,7 +150,8 @@ config SPI_BUTTERFLY
>
> config SPI_CLPS711X
> tristate "CLPS711X host SPI controller"
> - depends on ARCH_CLPS711X
> + depends on MFD_SYSCON
> + depends on ARCH_CLPS711X || COMPILE_TEST
> help
> This enables dedicated general purpose SPI/Microwire1-compatible
> master mode interface (SSI1) for CLPS711X-based CPUs.
> --
MFD_SYSCON is selected by ARCH_CLPS711X and this symbol is
not needed for COMPILE_TEST, so I am do not agree with this patch.
---
next prev parent reply other threads:[~2014-03-26 8:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 8:22 [PATCH] spi: clps711x: Enable driver compilation with COMPILE_TEST Axel Lin
2014-03-26 8:31 ` Alexander Shiyan [this message]
[not found] ` <1395822666.112180924-lVoEP/phaDtsdVUOrk1QfQ@public.gmane.org>
2014-03-26 8:34 ` Axel Lin
[not found] ` <CAFRkauAS-q0+z1YKvbU=j==faK48WHgWdDmSnjjtcEnJWG8syA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-26 8:36 ` Alexander Shiyan
[not found] ` <1395822990.6485242-lVoEP/phaDtsdVUOrk1QfQ@public.gmane.org>
2014-03-26 8:53 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395822666.112180924@f305.i.mail.ru \
--to=shc_work-jgs/udohzui@public.gmane.org \
--cc=axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox