From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Mark Brown <broonie@kernel.org>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-spi@vger.kernel.org, linux-sh@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH 00/18] spi: rspi: Add DMA support for QSPI on R-Car Gen2
Date: Mon, 2 Jun 2014 15:38:02 +0200 [thread overview]
Message-ID: <1401716301-29612-1-git-send-email-geert+renesas@glider.be> (raw)
This patch series refactors the Renesas SPI driver and adds DMA support
using the SPI DMA framework for QSPI on R-Car Gen2, for Single, Dual, and
Quad SPI Transfers.
It also adds DMA support for RZ/A1H, but this was untested.
Apart from refactorings that don't change behavior:
- [02/18] reverts a (harmless?) behavioral change for RSPI on SH,
- [03/18] removes 16-bit DMA support, which has no in-tree users.
16-bit DMA support requires using a double-sized buffer to
accomodate the interleaved data format.
If there's a strong requirement to keep this, I think it's best
to re-add support after this series.
- [09/18] drops the ability of RSPI on SH to work with a single DMA
channel, as the SPI DMA framework needs both RX and TX DMA
to function,
- [15/18] Adds DMA support for QSPI on R-Car Gen2,
- [16/18] Adds DMA support for RSPI on RZ/A1H,
- [18/18] adds DT preliminary DT support, as the format of the DMA
specifiers depends on the DT bindings for SHDMA, which are still
under development.
This was tested on r8a7791/koelsch (PIO and DMA), and r7s72100/genmai (PIO
only).
Performance figures for reading from a QSPI FLASH driven at 24.375 MHz
on r8a7791/koelsch are:
- Single: 1.1 Mbps PIO, 23 Mbps DMA
- Dual : 12.7 Mbps PIO, 48 Mbps DMA
- Quad : 13 Mbps PIO, 70 Mbps DMA
Thanks for your comments!
[01/18] spi: rspi: Extract rspi_wait_for_{tx_empty,rx_full}()
[02/18] spi: rspi: Do not call rspi_receive_init() for TX-only
[03/18] [RFC] spi: rspi: Remove unused 16-bit DMA support
[04/18] spi: rspi: Use core SPI_MASTER_MUST_[RT]X handling
[05/18] spi: rspi: Extract rspi_pio_transfer()
[06/18] spi: rspi: Don't consider DMA configuration failures fatal
[07/18] spi: rspi: Extract rspi_request_dma_chan()
[08/18] spi: rspi: Remove unneeded resource test in DMA setup
[09/18] spi: rspi: SPI DMA core needs both RX and TX DMA to function
[10/18] spi: rspi: Use SPI core DMA mapping framework
[11/18] spi: rspi: Move RSPI-specific setup out of DMA routines
[12/18] spi: rspi: Pass sg_tables instead of spi_tranfer to rspi_*_dma()
[13/18] spi: rspi: Merge rspi_*_dma() into rspi_dma_transfer()
[14/18] spi: rspi: Absorb rspi_rz_transfer_out_in() into
spi_rz_transfer_one()
[15/18] spi: rspi: Add DMA support for QSPI on R-Car Gen2
[16/18] spi: rspi: Add DMA support for RSPI on RZ/A1H
[17/18] spi: rspi: Extract rspi_common_transfer()
[18/18] [RFC] spi: rspi: Add DT support to DMA setup
Documentation/devicetree/bindings/spi/spi-rspi.txt | 6 +
drivers/spi/spi-rspi.c | 604 ++++++++-------------
include/linux/spi/rspi.h | 2 -
3 files changed, 228 insertions(+), 384 deletions(-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next reply other threads:[~2014-06-02 13:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 13:38 Geert Uytterhoeven [this message]
2014-06-02 13:38 ` [PATCH 01/18] spi: rspi: Extract rspi_wait_for_{tx_empty,rx_full}() Geert Uytterhoeven
2014-06-02 13:38 ` [PATCH 02/18] spi: rspi: Do not call rspi_receive_init() for TX-only Geert Uytterhoeven
2014-06-02 13:38 ` [PATCH 03/18] [RFC] spi: rspi: Remove unused 16-bit DMA support Geert Uytterhoeven
2014-06-02 13:38 ` [PATCH 05/18] spi: rspi: Extract rspi_pio_transfer() Geert Uytterhoeven
2014-06-02 13:38 ` [PATCH 06/18] spi: rspi: Don't consider DMA configuration failures fatal Geert Uytterhoeven
2014-06-02 13:38 ` [PATCH 09/18] spi: rspi: SPI DMA core needs both RX and TX DMA to function Geert Uytterhoeven
[not found] ` <1401716301-29612-10-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2014-06-02 14:42 ` Mark Brown
2014-06-02 14:55 ` Geert Uytterhoeven
[not found] ` <CAMuHMdXra=NjAy6WuQBf1Rm3iHv8J2qYubTpq3scxGq8+wK_tg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-02 16:28 ` Mark Brown
2014-06-02 13:38 ` [PATCH 12/18] spi: rspi: Pass sg_tables instead of spi_tranfer to rspi_*_dma() Geert Uytterhoeven
2014-06-02 13:38 ` [PATCH 13/18] spi: rspi: Merge rspi_*_dma() into rspi_dma_transfer() Geert Uytterhoeven
2014-06-02 13:38 ` [PATCH 14/18] spi: rspi: Absorb rspi_rz_transfer_out_in() into rspi_rz_transfer_one() Geert Uytterhoeven
2014-06-02 13:38 ` [PATCH 15/18] spi: rspi: Add DMA support for QSPI on R-Car Gen2 Geert Uytterhoeven
[not found] ` <1401716301-29612-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2014-06-02 13:38 ` [PATCH 04/18] spi: rspi: Use core SPI_MASTER_MUST_[RT]X handling Geert Uytterhoeven
2014-06-02 13:38 ` [PATCH 07/18] spi: rspi: Extract rspi_request_dma_chan() Geert Uytterhoeven
2014-06-02 13:38 ` [PATCH 08/18] spi: rspi: Remove unneeded resource test in DMA setup Geert Uytterhoeven
2014-06-02 13:38 ` [PATCH 10/18] spi: rspi: Use SPI core DMA mapping framework Geert Uytterhoeven
2014-06-02 13:38 ` [PATCH 11/18] spi: rspi: Move RSPI-specific setup out of DMA routines Geert Uytterhoeven
2014-06-02 13:38 ` [PATCH 16/18] spi: rspi: Add DMA support for RSPI on RZ/A1H Geert Uytterhoeven
2014-06-02 13:38 ` [PATCH 18/18] [RFC] spi: rspi: Add DT support to DMA setup Geert Uytterhoeven
2014-06-02 14:54 ` Mark Brown
[not found] ` <20140602145447.GJ31751-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-06-02 14:57 ` Geert Uytterhoeven
2014-06-02 13:38 ` [PATCH 17/18] spi: rspi: Extract rspi_common_transfer() Geert Uytterhoeven
2014-06-05 5:58 ` [PATCH 00/18] spi: rspi: Add DMA support for QSPI on R-Car Gen2 Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401716301-29612-1-git-send-email-geert+renesas@glider.be \
--to=geert+renesas@glider.be \
--cc=broonie@kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).