From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] spi: dw-pci: fix bug when regs left uninitialized
Date: Wed, 27 Aug 2014 17:53:19 +0300 [thread overview]
Message-ID: <1409151199.30155.20.camel@linux.intel.com> (raw)
In-Reply-To: <20140827144608.GE17528-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Wed, 2014-08-27 at 15:46 +0100, Mark Brown wrote:
> On Wed, Aug 27, 2014 at 04:21:12PM +0300, Andy Shevchenko wrote:
> > The commit 04f421e7 "spi: dw: use managed resources" changes drivers to use
> > managed functions, but seems wasn't properly tested in PCI case. The regs field
> > of struct dw_spi left uninitialized. Thus, kernel crashes when tries to access
> > to the SPI controller registers. This patch fixes the issue.
>
> Applied. Please use the Fixes: tag and use a minimum of 12 characters
> for the commit ID (to avoid collisions).
Noted, thank you!
--
Andy Shevchenko <andriy.shevchenko-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-08-27 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 13:21 [PATCH] spi: dw-pci: fix bug when regs left uninitialized Andy Shevchenko
2014-08-27 14:46 ` Mark Brown
[not found] ` <20140827144608.GE17528-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-08-27 14:53 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409151199.30155.20.camel@linux.intel.com \
--to=andriy.shevchenko-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).