From: Torsten Fleischer <torfl6749@gmail.com>
To: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org
Cc: Torsten Fleischer <torfl6749@gmail.com>
Subject: [PATCH 1/1] spi: spi-gpio: Add dt support for a single device with no chip select
Date: Mon, 27 Oct 2014 16:27:17 +0100 [thread overview]
Message-ID: <1414423637-2817-1-git-send-email-torfl6749@gmail.com> (raw)
From: Torsten Fleischer <torfl6749@gmail.com>
Use an empty 'cs-gpios' property if a single device is connected which
has no chip select.
This refers to the discussion at https://lkml.org/lkml/2013/11/13/62.
Signed-off-by: Torsten Fleischer <torfl6749@gmail.com>
---
Documentation/devicetree/bindings/spi/spi-gpio.txt | 6 ++++--
drivers/spi/spi-gpio.c | 10 +++++++---
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/spi/spi-gpio.txt b/Documentation/devicetree/bindings/spi/spi-gpio.txt
index 8a824be..ad8795f 100644
--- a/Documentation/devicetree/bindings/spi/spi-gpio.txt
+++ b/Documentation/devicetree/bindings/spi/spi-gpio.txt
@@ -8,8 +8,10 @@ Required properties:
- gpio-sck: GPIO spec for the SCK line to use
- gpio-miso: GPIO spec for the MISO line to use
- gpio-mosi: GPIO spec for the MOSI line to use
- - cs-gpios: GPIOs to use for chipselect lines
- - num-chipselects: number of chipselect lines
+ - cs-gpios: GPIOs to use for chipselect lines. Leave this property empty if
+ a single device with no chip select is connected.
+ - num-chipselects: Number of chipselect lines. Has to be "1" even if a single
+ device with no chip select is connected.
Example:
diff --git a/drivers/spi/spi-gpio.c b/drivers/spi/spi-gpio.c
index 9f59553..b343818a 100644
--- a/drivers/spi/spi-gpio.c
+++ b/drivers/spi/spi-gpio.c
@@ -461,9 +461,13 @@ static int spi_gpio_probe(struct platform_device *pdev)
* property of the node.
*/
- for (i = 0; i < SPI_N_CHIPSEL; i++)
- spi_gpio->cs_gpios[i] =
- of_get_named_gpio(np, "cs-gpios", i);
+ if ((SPI_N_CHIPSEL == 1) &&
+ (of_gpio_named_count(np, "cs-gpios") == 0))
+ spi_gpio->cs_gpios[0] = SPI_GPIO_NO_CHIPSELECT;
+ else
+ for (i = 0; i < SPI_N_CHIPSEL; i++)
+ spi_gpio->cs_gpios[i] =
+ of_get_named_gpio(np, "cs-gpios", i);
}
#endif
--
1.8.4.5
next reply other threads:[~2014-10-27 15:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 15:27 Torsten Fleischer [this message]
2014-10-27 17:30 ` [PATCH 1/1] spi: spi-gpio: Add dt support for a single device with no chip select Mark Rutland
2014-10-30 6:52 ` Torsten Fleischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414423637-2817-1-git-send-email-torfl6749@gmail.com \
--to=torfl6749@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).