From: Beniamino Galvani <b.galvani@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, Carlo Caione <carlo@caione.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Jerry Cao <jerry.cao@amlogic.com>,
Victor Wan <victor.wan@amlogic.com>,
Beniamino Galvani <b.galvani@gmail.com>
Subject: [PATCH v2 1/4] spi: Add 'last' flag to spi_transfer structure
Date: Mon, 17 Nov 2014 23:47:48 +0100 [thread overview]
Message-ID: <1416264471-774-2-git-send-email-b.galvani@gmail.com> (raw)
In-Reply-To: <1416264471-774-1-git-send-email-b.galvani@gmail.com>
Some drivers need to know whether the current transfer is the last in
the message in order to properly handle CS. A common way to achieve
this is to reimplement transfer_one_message() but this leads to
undesirable code duplication.
This patch adds a 'last' field to the spi_transfer structure and
populates it before passing the structure to the driver.
Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
---
drivers/spi/spi.c | 6 ++++++
include/linux/spi/spi.h | 2 ++
2 files changed, 8 insertions(+)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index ebcb33d..fc7f02d 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -887,6 +887,7 @@ static void spi_pump_messages(struct kthread_work *work)
{
struct spi_master *master =
container_of(work, struct spi_master, pump_messages);
+ struct spi_transfer *xfer;
unsigned long flags;
bool was_busy = false;
int ret;
@@ -941,6 +942,11 @@ static void spi_pump_messages(struct kthread_work *work)
}
}
+ list_for_each_entry(xfer, &master->cur_msg->transfers, transfer_list) {
+ xfer->last = list_is_last(&xfer->transfer_list,
+ &master->cur_msg->transfers);
+ }
+
if (!was_busy)
trace_spi_master_busy(master);
diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h
index 46d188a..37f055a 100644
--- a/include/linux/spi/spi.h
+++ b/include/linux/spi/spi.h
@@ -535,6 +535,7 @@ extern struct spi_master *spi_busnum_to_master(u16 busnum);
* (SPI_NBITS_SINGLE) is used.
* @rx_nbits: number of bits used for reading. If 0 the default
* (SPI_NBITS_SINGLE) is used.
+ * @last: whether the transfer is the last in the message.
* @len: size of rx and tx buffers (in bytes)
* @speed_hz: Select a speed other than the device default for this
* transfer. If 0 the default (from @spi_device) is used.
@@ -620,6 +621,7 @@ struct spi_transfer {
unsigned cs_change:1;
unsigned tx_nbits:3;
unsigned rx_nbits:3;
+ unsigned last:1;
#define SPI_NBITS_SINGLE 0x01 /* 1bit transfer */
#define SPI_NBITS_DUAL 0x02 /* 2bits transfer */
#define SPI_NBITS_QUAD 0x04 /* 4bits transfer */
--
1.9.1
next prev parent reply other threads:[~2014-11-17 22:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 22:47 [PATCH v2 0/4] spi: Add support for Amlogic Meson SPIFC Beniamino Galvani
2014-11-17 22:47 ` Beniamino Galvani [this message]
[not found] ` <1416264471-774-2-git-send-email-b.galvani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-18 14:06 ` [PATCH v2 1/4] spi: Add 'last' flag to spi_transfer structure Mark Brown
[not found] ` <20141118140658.GI22111-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-11-18 22:55 ` Beniamino Galvani
[not found] ` <20141118225546.GA27182-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-19 9:34 ` Mark Brown
2014-11-17 22:47 ` [PATCH v2 2/4] spi: meson: Add device tree bindings documentation for SPIFC Beniamino Galvani
2014-11-17 22:47 ` [PATCH v2 3/4] spi: meson: Add support for Amlogic Meson SPIFC Beniamino Galvani
2014-11-18 14:28 ` Mark Brown
[not found] ` <1416264471-774-1-git-send-email-b.galvani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-17 22:47 ` [PATCH v2 4/4] ARM: dts: meson: add node for SPIFC Beniamino Galvani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416264471-774-2-git-send-email-b.galvani@gmail.com \
--to=b.galvani@gmail.com \
--cc=broonie@kernel.org \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jerry.cao@amlogic.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=victor.wan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).