From: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: nizamhaider786-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/3] spi:spi-gpio: fixed space coding styple issue
Date: Mon, 05 Jan 2015 05:38:53 -0800 [thread overview]
Message-ID: <1420465133.2652.12.camel@perches.com> (raw)
In-Reply-To: <20150105133014.GP11764-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Mon, 2015-01-05 at 13:30 +0000, Mark Brown wrote:
> On Mon, Jan 05, 2015 at 04:36:03AM -0800, Joe Perches wrote:
> > On Mon, 2015-01-05 at 17:31 +0530, nizamhaider786-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> > > From: Nizam Haider <nizamhaider786-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> > > fixed a coding style issue
>
> > This is a checkpatch defect and not a coding styple (style) issue.
>
> > Please don't blindly take checkpatch messages as dicta.
>
> No, it's a coding style thing.
It's a coding style consistency thing.
> It may have been identified by
> checkpatch but that's what it is.
__pure is a #define for a gcc attribute
include/linux/compiler-gcc.h:#define __pure __attribute__((pure))
macro attributes are almost always used
with space separators in the kernel.
All instances of __pure in the kernel have
a space before the use.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-01-05 13:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 12:01 [PATCH 3/3] spi:spi-gpio: fixed space coding styple issue nizamhaider786-Re5JQEeQqe8AvxtiuMwx3w
2015-01-05 12:36 ` Joe Perches
[not found] ` <1420461363.2652.6.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2015-01-05 13:30 ` Mark Brown
[not found] ` <20150105133014.GP11764-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-01-05 13:38 ` Joe Perches [this message]
2015-01-05 18:32 ` Mark Brown
2015-01-05 18:46 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420465133.2652.12.camel@perches.com \
--to=joe-6d6dil74uinbdgjk7y7tuq@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nizamhaider786-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).