Re: [PATCH v1 1/1] spi: clarify what driver can do with message->status

[Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>]

On Tue, 2015-02-24 at 23:17 +0900, Mark Brown wrote:
> On Tue, Feb 24, 2015 at 03:33:27PM +0200, Andy Shevchenko wrote:
> > On Tue, 2015-02-24 at 22:24 +0900, Mark Brown wrote:
> 
> > > > +	/* The actual driver may set this field to indicate an error, e.g. -EIO
> > > > +	 * for failed transfer. */
> > > >  	int			status;
> 
> > > Let's take a step back here: what documentation are you looking at which
> > > says anything else about status?
> 
> > The description of this field above, namely " * @status: zero for
> > success, else negative errno".
> 
> ...which suggests that anything detecting an error should report it via
> status, no?

Unclear. I dived into spi.c to understand if I could override or not.
There are two fields status and state, the latter is dedicated for an
actual driver usage, and that is clear. Many (old) drivers are using
state as a storage for custom status. Newer drivers, that are using SPI
core, mostly don't care about error handling at all (at least I didn't
find an existing example of the message->status usage).


> > > I'd also expect this to go with the other kerneldoc for the field.
> 
> > Any place that suits better.
> 
> Well, see above...

Regarding my above comment can we extend the description of the field
then?

-- 
Andy Shevchenko <andriy.shevchenko-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html