From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [RFC/PATCHv2 3/3] spi: dw-spi: Pointers select 16b vs. 32b DesignWare access Date: Wed, 11 Mar 2015 12:27:16 +0200 Message-ID: <1426069636.14897.271.camel@linux.intel.com> References: <1425685594-26595-1-git-send-email-tthayer@opensource.altera.com> <1425685594-26595-4-git-send-email-tthayer@opensource.altera.com> <54FDDFE6.8010109@opensource.altera.com> <54FDF8BB.4050202@opensource.altera.com> <54FF556A.3020408@opensource.altera.com> <54FF6E91.1010704@opensource.altera.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Andy Shevchenko , Mark Brown , Grant Likely , Jiri Kosina , Pawel Moll , Rob Herring , Mark Rutland , ijc+devicetree , dinguyen , Linux Documentation List , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree , Thor Thayer , Axel Lin , baruch , Jingoo Han , Kumar Gala To: tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org Return-path: In-Reply-To: <54FF6E91.1010704-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Tue, 2015-03-10 at 17:22 -0500, Thor Thayer wrote: > > However, I'm now considering what if we just replace > > dw_{write/read}w() by l-variants without any additional DT property > > and accessor functions? > > Would it work for both your cases (old chip, new chip)? > > On my side I may test this on Intel MID. > > > > Yes, this would be the simplest solution. The l-variant certainly works > on our legacy SoCs. I'll be curious to hear your testing results. Whenever you send a new version of patch. > The data sheet mentions that registers are addressed at 32-bit > boundaries to remain consistent with the AHB bus (Section 6.1 of > dw_apb_ssi_db.pdf). Additionally unused bits are reserved for writes > and 0 for reads so this seems like a good solution. > > My concern is the presence of legacy devices that I have no way of > testing. Is a Request For Test in the body of the patch sufficient? Better to write this wider in cover letter or (in case of one patch) in additional description usually located after '---' line. Since I fixed couple of bugs in core I'm not sure we have a lot of users. Nevertheless, can you check who was recent and / or active contributor to spi-dw-mmio.c and put him / her to Cc list. -- Andy Shevchenko Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html