From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Chen,
Alvin" <alvin.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Jarkko Nikula
<jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Subject: Re: [PATCH v1 2/2] spi: pxa2xx: replace ugly table by approximation
Date: Wed, 25 Mar 2015 17:28:42 +0200 [thread overview]
Message-ID: <1427297322.14897.409.camel@linux.intel.com> (raw)
In-Reply-To: <20150325151701.GB3572-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Wed, 2015-03-25 at 08:17 -0700, Mark Brown wrote:
> On Wed, Mar 25, 2015 at 12:37:45PM +0200, Andy Shevchenko wrote:
> > On Tue, 2015-03-24 at 09:59 -0700, Mark Brown wrote:
>
> > > I'm not sure that
> > > one could reasonably expect someone to follow this code without doing
> > > detective work. I think the biggest thing is that the comments aren't
> > > saying why the code is doing what it's doing.
>
> > Should I cite data sheet in case to explain some branches?
>
> Yes, that should be helpful.
I early today sent v2, I hope it becomes more clear.
--
Andy Shevchenko <andriy.shevchenko-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-03-25 15:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 15:43 [PATCH v1 0/2] spi: pxa2xx: allow to set mostly any baudrate for Quark case Andy Shevchenko
[not found] ` <1427211802-217454-1-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-03-24 15:43 ` [PATCH v1 1/2] spi: pxa2xx: shift clk_div in one place Andy Shevchenko
[not found] ` <1427211802-217454-2-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-03-24 17:00 ` Mark Brown
2015-03-24 15:43 ` [PATCH v1 2/2] spi: pxa2xx: replace ugly table by approximation Andy Shevchenko
[not found] ` <1427211802-217454-3-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-03-24 16:59 ` Mark Brown
[not found] ` <20150324165954.GL17265-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-03-25 10:37 ` Andy Shevchenko
[not found] ` <1427279865.14897.405.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-03-25 15:17 ` Mark Brown
[not found] ` <20150325151701.GB3572-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-03-25 15:28 ` Andy Shevchenko [this message]
2015-03-24 16:23 ` [PATCH v1 0/2] spi: pxa2xx: allow to set mostly any baudrate for Quark case Mark Brown
[not found] ` <20150324162323.GH17265-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-03-24 16:27 ` Andy Shevchenko
[not found] ` <1427214452.14897.401.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-03-24 16:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427297322.14897.409.camel@linux.intel.com \
--to=andriy.shevchenko-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=alvin.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).