From: Pelle Nilsson <per.nilsson-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org>
To: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
nios2-dev-g9ZBwUv/Ih/yUk5EbOjzuce+I+R0W71w@public.gmane.org
Subject: [PATCH 0/1] Fix NULL pointer dereference
Date: Thu, 9 Apr 2015 17:03:41 +0200 [thread overview]
Message-ID: <1428591822-24279-1-git-send-email-per.nilsson@xelmo.com> (raw)
As I reported earlier, spi-altera driver is broken and causes a kernel
panic due to a NULL pointer dereference during first SPI
transaction. On a closer look, it turned out that the setup_transfer()
bitbang callback is mandatory when the txrx_bufs() callback is
present. It was therefore an error to remove it in commit
30af9b558a56. This patch simply adds back an empty implementation of
the callback.
Pelle Nilsson (1):
spi: altera: Add empty implementation of setup_transfer callback
drivers/spi/spi-altera.c | 6 ++++++
1 file changed, 6 insertions(+)
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2015-04-09 15:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 15:03 Pelle Nilsson [this message]
[not found] ` <1428591822-24279-1-git-send-email-per.nilsson-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org>
2015-04-09 15:03 ` [PATCH 1/1] spi: altera: Add empty implementation of setup_transfer callback Pelle Nilsson
[not found] ` <1428591822-24279-2-git-send-email-per.nilsson-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org>
2015-04-09 15:40 ` Mark Brown
[not found] ` <20150409154045.GZ6023-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-04-09 15:50 ` Pelle Nilsson
[not found] ` <55269FDC.8040306-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org>
2015-04-09 16:10 ` Mark Brown
2015-04-13 9:45 ` Pelle Nilsson
[not found] ` <552B9045.4040709-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org>
2015-04-13 10:08 ` [PATCH] spi: bitbang: Make setup_transfer callback optional Pelle Nilsson
[not found] ` <1428919685-14190-1-git-send-email-per.nilsson-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org>
2015-04-14 0:22 ` [Nios2-dev] " Ezequiel Garcia
2015-04-14 13:40 ` [PATCH v2] spi: bitbang: Make setup_transfer() " Pelle Nilsson
[not found] ` <1429018817-18117-1-git-send-email-per.nilsson-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org>
2015-04-14 15:36 ` Ezequiel Garcia
2015-04-18 11:00 ` Mark Brown
2015-04-09 15:26 ` [PATCH 0/1] Fix NULL pointer dereference Mark Brown
2015-04-09 15:54 ` [PATCH v2] spi: altera: Add empty implementation of setup_transfer callback Pelle Nilsson
[not found] ` <1428594853-24640-1-git-send-email-per.nilsson-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org>
2015-04-09 16:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428591822-24279-1-git-send-email-per.nilsson@xelmo.com \
--to=per.nilsson-5twez6kpplyavxtiumwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nios2-dev-g9ZBwUv/Ih/yUk5EbOjzuce+I+R0W71w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).