From: Guenter Roeck <linux@roeck-us.net>
To: linux-kernel@vger.kernel.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Guenter Roeck <linux@roeck-us.net>,
Martin Sperl <kernel@martin.sperl.org>,
linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: [PATCH resend 1/5] spi: bcm2835: Add GPIOLIB dependency
Date: Mon, 4 May 2015 15:30:45 -0700 [thread overview]
Message-ID: <1430778649-28126-2-git-send-email-linux@roeck-us.net> (raw)
In-Reply-To: <1430778649-28126-1-git-send-email-linux@roeck-us.net>
Fix:
drivers/spi/spi-bcm2835.c: In function 'chip_match_name':
drivers/spi/spi-bcm2835.c:356:21: error:
dereferencing pointer to incomplete type
drivers/spi/spi-bcm2835.c: In function 'bcm2835_spi_setup':
drivers/spi/spi-bcm2835.c:382:2: error:
` implicit declaration of function 'gpiochip_find'
drivers/spi/spi-bcm2835.c:387:21: error:
dereferencing pointer to incomplete type
by adding the now mandatory GPIOLIB dependency.
Fixes: a30a555d7435 ("spi: bcm2835: transform native-cs to gpio-cs
on first spi_setup")
Cc: Martin Sperl <kernel@martin.sperl.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
Yes, I know, this patch is in -next. Please see this e-mail as gentle reminder
to consider pushing it (or one of the other patches fixing the same problem)
into mainline.
drivers/spi/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 198f96b7fb45..a132180a9251 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -78,6 +78,7 @@ config SPI_ATMEL
config SPI_BCM2835
tristate "BCM2835 SPI controller"
depends on ARCH_BCM2835 || COMPILE_TEST
+ depends on GPIOLIB
help
This selects a driver for the Broadcom BCM2835 SPI master.
--
2.1.0
next parent reply other threads:[~2015-05-04 22:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1430778649-28126-1-git-send-email-linux@roeck-us.net>
2015-05-04 22:30 ` Guenter Roeck [this message]
[not found] ` <1430778649-28126-2-git-send-email-linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-05-04 23:34 ` [PATCH resend 1/5] spi: bcm2835: Add GPIOLIB dependency Mark Brown
[not found] ` <20150504233421.GW22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-05 0:02 ` Guenter Roeck
[not found] ` <55480894.3080200-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-05-05 2:00 ` Guenter Roeck
[not found] ` <55482457.2020005-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-05-05 11:16 ` Mark Brown
[not found] ` <20150505111646.GB22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-05 11:32 ` Geert Uytterhoeven
[not found] ` <CAMuHMdXfW6ngPDNgzoe8FjNV9kC6YCo85C75umta5cC67WRVrg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-05 11:40 ` Mark Brown
2015-05-05 10:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430778649-28126-2-git-send-email-linux@roeck-us.net \
--to=linux@roeck-us.net \
--cc=broonie@kernel.org \
--cc=geert@linux-m68k.org \
--cc=kernel@martin.sperl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox