From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-spi@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
Mark Brown <broonie@kernel.org>, Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
<stable@vger.kernel.org>
Subject: [PATCH v2] ARM: pxa: ssp: Fix build error by removing originally incorrect DT binding
Date: Mon, 7 Sep 2015 10:23:01 +0300 [thread overview]
Message-ID: <1441610581-11434-1-git-send-email-jarkko.nikula@linux.intel.com> (raw)
Commit 03fbf488cece ("spi: pxa2xx: Differentiate Intel LPSS types") caused
build error here because it removed the type LPSS_SSP and I didn't notice
the type was used here too.
I believe commit a6e56c28a178 ("ARM: pxa: ssp: add DT bindings") added it
accidentally by copying all enum pxa_ssp_type types from
include/linux/pxa2xx_ssp.h even LPSS_SSP was for Intel LPSS SPI devices.
Fix the build error by removing this incorrect binding.
Fixes: 03fbf488cece ("spi: pxa2xx: Differentiate Intel LPSS types")
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Reported-by: Axel Lin <axel.lin@ingics.com>
Cc: <stable@vger.kernel.org> # 4.2
---
v2: Added Fixes tag suggested by Robert Jarzmik
---
arch/arm/plat-pxa/ssp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c
index ad9529cc4203..daa1a65f2eb7 100644
--- a/arch/arm/plat-pxa/ssp.c
+++ b/arch/arm/plat-pxa/ssp.c
@@ -107,7 +107,6 @@ static const struct of_device_id pxa_ssp_of_ids[] = {
{ .compatible = "mvrl,pxa168-ssp", .data = (void *) PXA168_SSP },
{ .compatible = "mrvl,pxa910-ssp", .data = (void *) PXA910_SSP },
{ .compatible = "mrvl,ce4100-ssp", .data = (void *) CE4100_SSP },
- { .compatible = "mrvl,lpss-ssp", .data = (void *) LPSS_SSP },
{ },
};
MODULE_DEVICE_TABLE(of, pxa_ssp_of_ids);
--
2.5.1
next reply other threads:[~2015-09-07 7:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 7:23 Jarkko Nikula [this message]
2015-09-12 13:43 ` [PATCH v2] ARM: pxa: ssp: Fix build error by removing originally incorrect DT binding Robert Jarzmik
[not found] ` <87zj0rsqhe.fsf-4ty26DBLk+jEm7gnYqmdkQ@public.gmane.org>
2015-09-21 7:48 ` Jarkko Nikula
2015-09-21 9:03 ` Robert Jarzmik
[not found] ` <87fv28qh49.fsf-4ty26DBLk+jEm7gnYqmdkQ@public.gmane.org>
2015-09-21 15:15 ` Vinod Koul
2015-09-21 18:06 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441610581-11434-1-git-send-email-jarkko.nikula@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=robert.jarzmik@free.fr \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).