Re: [PATCH 1/2] spi/bcm63xx: document device tree bindings

Florian Fainelli
2015-09-10T19:17:40Z

On 10/09/15 08:29, Jonas Gorski wrote:
> Add documentation for the bindings of the low speed SPI controller found
> on most bcm63xx SoCs.
>
> Signed-off-by: Jonas Gorski <jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
> ---
> .../devicetree/bindings/spi/spi-bcm63xx.txt | 33 ++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/spi/spi-bcm63xx.txt
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-bcm63xx.txt b/Documentation/devicetree/bindings/spi/spi-bcm63xx.txt
> new file mode 100644
> index 0000000..1a60bb9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/spi-bcm63xx.txt
> @@ -0,0 +1,33 @@
> +Binding for Broadcom BCM6348/BCM6358 SPI controller
> +
> +Required properties:
> +- compatible: must contain one of "brcm,bcm6348-spi", "brcm,bcm6458-spi".

Typo, the second compatible should "brcm,bcm6358-spi", other than that:

Reviewed-by: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

> +- reg: Base address and size of the controllers memory area.
> +- interrupts: Interrupt for the SPI block.
> +- clocks: phandle of the SPI clock.
> +- clock-names: has to be "spi".
> +- #address-cells: <1>, as required by generic SPI binding.
> +- #size-cells: <0>, also as required by generic SPI binding.
> +
> +Optional properties:
> +- num-cs: some controllers have less than 8 cs signals. Defaults to 8
> + if absent.
> +
> +Child nodes as per the generic SPI binding.
> +
> +Example:
> +
> + spi@10000800 {
> + compatible = "brcm,bcm6368-spi", "brcm,bcm6358-spi";
> + reg = <0x10000800 0x70c>;
> +
> + interrupts = <1>;
> +
> + clocks = <&clkctl 9>;
> + clock-names = "spi";
> +
> + num-cs = <5>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };