From: Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Nicolas Ferre
<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
Daniel Mack <daniel-cYrQPVfZoowdnm+yROfE0A@public.gmane.org>,
Haojian Zhuang
<haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org>,
Kukjin Kim <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Krzysztof Kozlowski
<k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Jarkko Nikula
<jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Subject: [PATCH 06/16] spi: au1550: Simplify au1550_spi_setupxfer()
Date: Tue, 15 Sep 2015 16:26:18 +0300 [thread overview]
Message-ID: <1442323588-29642-6-git-send-email-jarkko.nikula@linux.intel.com> (raw)
In-Reply-To: <1442323588-29642-1-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
SPI core validates both bits_per_word and speed_hz transfer parameters and
defaults to spi->bits_per_word and spi->max_speed_hz in case these per
transfer parameters are not set. This can simplify a little the
au1550_spi_setupxfer() as there is need to check only for valid
"struct spi_transfer" pointer.
Signed-off-by: Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
drivers/spi/spi-au1550.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/spi/spi-au1550.c b/drivers/spi/spi-au1550.c
index f45e085c01a6..afd239d6dec1 100644
--- a/drivers/spi/spi-au1550.c
+++ b/drivers/spi/spi-au1550.c
@@ -233,13 +233,12 @@ static int au1550_spi_setupxfer(struct spi_device *spi, struct spi_transfer *t)
unsigned bpw, hz;
u32 cfg, stat;
- bpw = spi->bits_per_word;
- hz = spi->max_speed_hz;
if (t) {
- if (t->bits_per_word)
- bpw = t->bits_per_word;
- if (t->speed_hz)
- hz = t->speed_hz;
+ bpw = t->bits_per_word;
+ hz = t->speed_hz;
+ } else {
+ bpw = spi->bits_per_word;
+ hz = spi->max_speed_hz;
}
if (!hz)
--
2.5.1
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-09-15 13:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 13:26 [PATCH 01/16] spi: txx9: Use transfer speed unconditionally Jarkko Nikula
[not found] ` <1442323588-29642-1-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-15 13:26 ` [PATCH 02/16] spi: s3c64xx: " Jarkko Nikula
[not found] ` <1442323588-29642-2-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-16 20:02 ` Applied "spi: s3c64xx: Use transfer speed unconditionally" to the spi tree Mark Brown
2015-09-15 13:26 ` [PATCH 03/16] spi: octeon: Use transfer speed unconditionally Jarkko Nikula
[not found] ` <1442323588-29642-3-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-16 20:02 ` Applied "spi: octeon: Use transfer speed unconditionally" to the spi tree Mark Brown
2015-09-15 13:26 ` [PATCH 04/16] spi: bfin-sport: Calculate transfer speed unconditionally Jarkko Nikula
[not found] ` <1442323588-29642-4-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-16 20:02 ` Applied "spi: bfin-sport: Calculate transfer speed unconditionally" to the spi tree Mark Brown
2015-09-15 13:26 ` [PATCH 05/16] spi: spi-bfin5xx: Calculate transfer speed unconditionally Jarkko Nikula
[not found] ` <1442323588-29642-5-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-16 20:02 ` Applied "spi: spi-bfin5xx: Calculate transfer speed unconditionally" to the spi tree Mark Brown
2015-09-15 13:26 ` Jarkko Nikula [this message]
[not found] ` <1442323588-29642-6-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-16 20:02 ` Applied "spi: au1550: Simplify au1550_spi_setupxfer()" " Mark Brown
2015-09-15 13:26 ` [PATCH 07/16] spi: mpc512x: Call mpc512x_psc_spi_transfer_setup() unconditionally Jarkko Nikula
[not found] ` <1442323588-29642-7-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-17 17:37 ` Applied "spi: mpc512x: Call mpc512x_psc_spi_transfer_setup() unconditionally" to the spi tree Mark Brown
2015-09-15 13:26 ` [PATCH 08/16] spi: omap-uwire: Remove needless bits_per_word and speed_hz tests Jarkko Nikula
[not found] ` <1442323588-29642-8-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-17 17:37 ` Applied "spi: omap-uwire: Remove needless bits_per_word and speed_hz tests" to the spi tree Mark Brown
2015-09-15 13:26 ` [PATCH 09/16] spi: omap-100k: Rely on validations done by spi core Jarkko Nikula
[not found] ` <1442323588-29642-9-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-17 17:37 ` Applied "spi: omap-100k: Rely on validations done by spi core" to the spi tree Mark Brown
2015-09-15 13:26 ` [PATCH 10/16] spi: atmel: Remove needless bits_per_word and speed_hz tests Jarkko Nikula
[not found] ` <1442323588-29642-10-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-15 13:54 ` Nicolas Ferre
2015-09-25 18:09 ` Applied "spi: atmel: Remove needless bits_per_word and speed_hz tests" to the spi tree Mark Brown
2015-09-15 13:26 ` [PATCH 11/16] spi: dw: Remove needless if statements Jarkko Nikula
[not found] ` <1442323588-29642-11-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-17 17:37 ` Applied "spi: dw: Remove needless if statements" to the spi tree Mark Brown
2015-09-15 13:26 ` [PATCH 12/16] spi: dw: Remove test for non-zero spi->max_speed_hz Jarkko Nikula
[not found] ` <1442323588-29642-12-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-17 17:37 ` Applied "spi: dw: Remove test for non-zero spi->max_speed_hz" to the spi tree Mark Brown
2015-09-15 13:26 ` [PATCH 13/16] spi: spi-fsl-dspi: Remove duplicated register write Jarkko Nikula
[not found] ` <1442323588-29642-13-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-17 17:37 ` Applied "spi: spi-fsl-dspi: Remove duplicated register write" to the spi tree Mark Brown
2015-09-15 13:26 ` [PATCH 14/16] spi: pxa2xx: Remove two variables from struct chip_data Jarkko Nikula
[not found] ` <1442323588-29642-14-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-17 17:37 ` Applied "spi: pxa2xx: Remove two variables from struct chip_data" to the spi tree Mark Brown
2015-09-15 13:26 ` [PATCH 15/16] spi: pxa2xx: Remove if statement that is always true in pump_transfers() Jarkko Nikula
[not found] ` <1442323588-29642-15-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-17 17:37 ` Applied "spi: pxa2xx: Remove if statement that is always true in pump_transfers()" to the spi tree Mark Brown
2015-09-15 13:26 ` [PATCH 16/16] spi: pxa2xx: Remove cr0 variable from struct chip_data Jarkko Nikula
[not found] ` <1442323588-29642-16-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-17 17:37 ` Applied "spi: pxa2xx: Remove cr0 variable from struct chip_data" to the spi tree Mark Brown
2015-09-16 19:52 ` [PATCH 01/16] spi: txx9: Use transfer speed unconditionally Mark Brown
2015-09-16 20:02 ` Applied "spi: txx9: Use transfer speed unconditionally" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442323588-29642-6-git-send-email-jarkko.nikula@linux.intel.com \
--to=jarkko.nikula-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=daniel-cYrQPVfZoowdnm+yROfE0A@public.gmane.org \
--cc=haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=robert.jarzmik-GANU6spQydw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).