linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Franklin S Cooper Jr <fcooper@ti.com>
To: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	broonie@kernel.org, nsekhar@ti.com, ssantosh@kernel.org,
	iivanov@mm-sol.com, m-karicheri2@ti.com
Cc: Franklin S Cooper Jr <fcooper@ti.com>
Subject: [RFC][PATCH] spi: Setup the master controller driver before setting the chipselect
Date: Mon, 12 Oct 2015 16:01:11 -0500	[thread overview]
Message-ID: <1444683671-15570-2-git-send-email-fcooper@ti.com> (raw)
In-Reply-To: <1444683671-15570-1-git-send-email-fcooper@ti.com>

Some devices depend on the master controller driver setup function being
called before calling any chipselect functions.

Insure that this is done otherwise uninitialized structures may be
accessed causing a kernel panic.

Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
 drivers/spi/spi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 38006cc..9374d82 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -2053,11 +2053,11 @@ int spi_setup(struct spi_device *spi)
 	if (!spi->max_speed_hz)
 		spi->max_speed_hz = spi->master->max_speed_hz;
 
-	spi_set_cs(spi, false);
-
 	if (spi->master->setup)
 		status = spi->master->setup(spi);
 
+	spi_set_cs(spi, false);
+
 	dev_dbg(&spi->dev, "setup mode %d, %s%s%s%s%u bits/w, %u Hz max --> %d\n",
 			(int) (spi->mode & (SPI_CPOL | SPI_CPHA)),
 			(spi->mode & SPI_CS_HIGH) ? "cs_high, " : "",
-- 
2.6.1

  reply	other threads:[~2015-10-12 21:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-12 21:01 [RFC] spi: Switch call order of spi master setup and spi_set_cs Franklin S Cooper Jr
2015-10-12 21:01 ` Franklin S Cooper Jr [this message]
     [not found]   ` <1444683671-15570-2-git-send-email-fcooper-l0cyMroinI0@public.gmane.org>
2015-10-14  9:47     ` [RFC][PATCH] spi: Setup the master controller driver before setting the chipselect Ivan T. Ivanov
     [not found]       ` <32A34513-E312-40FD-9390-B080A85822B7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-10-14 11:08         ` Andy Shevchenko
2015-10-14 11:45           ` Heiner Kallweit
     [not found]             ` <CAFSsGVtXP_Jd+CxvxfWCLXT_f+Tgv5SSZAbnBciqfr_BQMEZhA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-15 20:50               ` Franklin S Cooper Jr.
2015-10-28  0:52     ` Applied "spi: Setup the master controller driver before setting the chipselect" to the spi tree Mark Brown
     [not found] ` <1444683671-15570-1-git-send-email-fcooper-l0cyMroinI0@public.gmane.org>
2015-10-13 12:10   ` [RFC] spi: Switch call order of spi master setup and spi_set_cs Mark Brown
2015-10-13 14:03     ` Franklin S Cooper Jr.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444683671-15570-2-git-send-email-fcooper@ti.com \
    --to=fcooper@ti.com \
    --cc=broonie@kernel.org \
    --cc=iivanov@mm-sol.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=m-karicheri2@ti.com \
    --cc=nsekhar@ti.com \
    --cc=ssantosh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).