From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH v2 7/8] spi: lm70llp: use dev_warn
Date: Mon, 7 Dec 2015 16:17:34 +0530 [thread overview]
Message-ID: <1449485255-1103-7-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1449485255-1103-1-git-send-email-sudipm.mukherjee@gmail.com>
As we have a struct device available it is better to use dev_warn()
instead of printk.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/spi/spi-lm70llp.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi-lm70llp.c b/drivers/spi/spi-lm70llp.c
index 9d45a63..393eb2b 100644
--- a/drivers/spi/spi-lm70llp.c
+++ b/drivers/spi/spi-lm70llp.c
@@ -249,9 +249,8 @@ static void spi_lm70llp_attach(struct parport *p)
*/
status = spi_bitbang_start(&pp->bitbang);
if (status < 0) {
- printk(KERN_WARNING
- "%s: spi_bitbang_start failed with status %d\n",
- DRVNAME, status);
+ dev_warn(&pd->dev, "spi_bitbang_start failed with status %d\n",
+ status);
goto out_off_and_release;
}
@@ -278,7 +277,7 @@ static void spi_lm70llp_attach(struct parport *p)
dev_dbg(&pp->spidev_lm70->dev, "spidev_lm70 at %s\n",
dev_name(&pp->spidev_lm70->dev));
else {
- printk(KERN_WARNING "%s: spi_new_device failed\n", DRVNAME);
+ dev_warn(&pd->dev, "spi_new_device failed\n");
status = -ENODEV;
goto out_bitbang_stop;
}
--
1.9.1
next prev parent reply other threads:[~2015-12-07 10:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 10:47 [PATCH v2 1/8] spi: lm70llp: remove multiple blank lines Sudip Mukherjee
2015-12-07 10:47 ` [PATCH v2 4/8] spi: lm70llp: correct alignment Sudip Mukherjee
2015-12-07 10:47 ` [PATCH v2 5/8] spi: lm70llp: remove space Sudip Mukherjee
2015-12-07 10:47 ` [PATCH v2 6/8] spi: lm70llp: use new parport device model Sudip Mukherjee
2015-12-07 10:47 ` Sudip Mukherjee [this message]
[not found] ` <1449485255-1103-7-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-12-07 20:09 ` Applied "spi: lm70llp: use dev_warn" to the spi tree Mark Brown
[not found] ` <1449485255-1103-1-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-12-07 10:47 ` [PATCH v2 2/8] spi: lm70llp: add blank line after declaration Sudip Mukherjee
2015-12-07 10:47 ` [PATCH v2 3/8] spi: lm70llp: remove cast to void Sudip Mukherjee
2015-12-07 10:47 ` [PATCH v2 8/8] spi: lm70llp: remove printk Sudip Mukherjee
2015-12-07 20:07 ` [PATCH v2 1/8] spi: lm70llp: remove multiple blank lines Mark Brown
2015-12-08 4:33 ` Sudip Mukherjee
2015-12-08 12:49 ` Mark Brown
[not found] ` <20151208124956.GR5727-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-12-08 14:30 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449485255-1103-7-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).