From: Bastien Nocera <hadess@hadess.net>
To: Aaron Lu <aaron.lu@intel.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: ACPI Devel Mailing List <linux-acpi@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Stephen Just <stephenjust@gmail.com>,
"Chen, Yu C" <yu.c.chen@intel.com>,
linux-spi@vger.kernel.org
Subject: Re: [PATCH] ACPI / scan: set status to 0 if _STA failed
Date: Wed, 09 Dec 2015 16:40:22 +0100 [thread overview]
Message-ID: <1449675622.3723.4.camel@hadess.net> (raw)
In-Reply-To: <564D3C75.60208@intel.com>
On Thu, 2015-11-19 at 11:05 +0800, Aaron Lu wrote:
> Some ACPI node's _STA will touch operation region field, since the
> evaluation of _STA in acpi_bus_type_and_status is very early, the
> operation region handler is not ready yet. Instead of fail that
> function
> and not creating the acpi_device node consequently, set status to 0
> so
> that later when the driver for that device is probing, it can find
> the acpi_device node and proceed normally. And at that time, the
> handler for the operation region is ready and its _STA evaluation
> will
> succeed, its present status can be checked there.
>
> Even there will be no driver using this node later, it doesn't seem
> hurt to have one more acpi_device node created with status set to 0.
>
> This happens on Microsoft Surface 3, where the SPI device node NTRG's
> _STA touches GPIO fields and the SPI core driver will only enumerate
> SPI
> devices from ACPI if the acpi_device node is 1: created; 2: _STA
> indicates it's present.
>
> Note that due to another problem in SPI driver, for NTRG to be
> actually
> enumerated, some changes have to be made in the SPI layer, which is
> addressed by Mika(not send out yet):
> https://bugzilla.kernel.org/show_bug.cgi?id=104291#c23
>
> Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=104291
> Reported-by: Bastien Nocera <bugzilla@hadess.net>
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
Worked for me with the additional SPI patch on a Surface 3.
Tested-by: Bastien Nocera <hadess@hadess.net>
prev parent reply other threads:[~2015-12-09 15:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 3:05 [PATCH] ACPI / scan: set status to 0 if _STA failed Aaron Lu
2015-11-19 10:11 ` Mika Westerberg
[not found] ` <20151119101149.GZ1604-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-12-14 23:42 ` Rafael J. Wysocki
2015-12-09 15:40 ` Bastien Nocera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449675622.3723.4.camel@hadess.net \
--to=hadess@hadess.net \
--cc=aaron.lu@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=stephenjust@gmail.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).