linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ranjit Waghmode <ranjit.waghmode@xilinx.com>
To: <broonie@kernel.org>, <dwmw2@infradead.org>,
	<computersforpeace@gmail.com>, <swarren@nvidia.com>,
	<geert+renesas@glider.be>, <afd@ti.com>, <jic23@kernel.org>,
	<marex@denx.de>, <jteki@openedev.com>, <zajec5@gmail.com>,
	<juhosg@openwrt.org>, <mika.westerberg@linux.intel.com>,
	<sean.nyekjaer@prevas.dk>, <beanhuo@micron.com>,
	<furquan@google.com>, <michal.simek@xilinx.com>,
	<soren.brinkmann@xilinx.com>
Cc: <linux-spi@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <harinik@xilinx.com>,
	<punnaia@xilinx.com>, <ran27jit@gmail.com>,
	"Ranjit Waghmode" <ranjit.waghmode@xilinx.com>
Subject: [LINUX RFC v3 1/4] spi: addng support for data stripe feature in core
Date: Mon, 14 Dec 2015 18:39:42 +0530	[thread overview]
Message-ID: <1450098585-3129-2-git-send-email-ranjit.waghmode@xilinx.com> (raw)
In-Reply-To: <1450098585-3129-1-git-send-email-ranjit.waghmode@xilinx.com>

This patch enables data stripe feature in spi core. This feature is
required to support dual parallel mode of ZynqMP GQSPI controller.

To achieve the same an API SPI_MASTER_DATA_STRIPE is added.
With data stripe enabled,
  - even bytes i.e. 0, 2, 4,... are transmitted on lower data bus
  - odd bytes i.e. 1, 3, 5,.. are transmitted on upper data bus.

To support data stripe; need to  assert both chip selects once.
This is achieved throught API SPI_MASTER_BOTH_CS.

Signed-off-by: Ranjit Waghmode <ranjit.waghmode@xilinx.com>

---
V3 Changes:
	- Updated comments for newly added APIs.
	- Changed patch description for ease of understanding
V2 Changes:
	- Added error handling condition for newly added features
---

 drivers/spi/spi.c       |  8 ++++++++
 include/linux/spi/spi.h | 11 +++++++++++
 2 files changed, 19 insertions(+)

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 2b0a8ec..930dac3 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -2106,6 +2106,14 @@ static int __spi_validate(struct spi_device *spi, struct spi_message *message)
 	if (list_empty(&message->transfers))
 		return -EINVAL;

+	/*
+	 * Data stripe option is selected if and only if when
+	 * two chips are enabled
+	 */
+	if ((master->flags & SPI_MASTER_DATA_STRIPE)
+		&& !(master->flags & SPI_MASTER_BOTH_CS))
+			return -EINVAL;
+
 	/* Half-duplex links include original MicroWire, and ones with
 	 * only one data pin like SPI_3WIRE (switches direction) or where
 	 * either MOSI or MISO is missing.  They can also be caused by
diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h
index cce80e6..e83b667 100644
--- a/include/linux/spi/spi.h
+++ b/include/linux/spi/spi.h
@@ -424,6 +424,17 @@ struct spi_master {
 #define SPI_MASTER_NO_TX	BIT(2)		/* can't do buffer write */
 #define SPI_MASTER_MUST_RX      BIT(3)		/* requires rx */
 #define SPI_MASTER_MUST_TX      BIT(4)		/* requires tx */
+	/* Controller may support data stripe feature when more than one
+	 * chips are present.
+	 * Setting data stripe will send data in following manner:
+	 * -> even bytes i.e. 0, 2, 4,... are transmitted on lower data bus
+	 * -> odd bytes i.e. 1, 3, 5,.. are transmitted on upper data bus
+	 */
+#define SPI_MASTER_DATA_STRIPE	BIT(7)		/* support data stripe */
+	/* Controller may support asserting more than one chip select at once.
+	 * This flag will enable that feature.
+	 */
+#define SPI_MASTER_BOTH_CS	BIT(8)		/* assert both chip selects */

 	/* lock and mutex for SPI bus locking */
 	spinlock_t		bus_lock_spinlock;
--
2.1.2

  reply	other threads:[~2015-12-14 13:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-14 13:09 [LINUX RFC v3 0/4] spi: add dual parallel mode support in Zynq MPSoC GQSPI controller Ranjit Waghmode
2015-12-14 13:09 ` Ranjit Waghmode [this message]
2015-12-14 13:09 ` [LINUX RFC v3 2/4] mtd: add spi_device instance to spi_nor struct Ranjit Waghmode
2015-12-14 13:09 ` [LINUX RFC v3 3/4] mtd: spi-nor: add dual parallel mode support Ranjit Waghmode
2015-12-14 13:09 ` [LINUX RFC v3 4/4] spi: zynqmp: gqspi: add support for dual parallel mode configuration Ranjit Waghmode

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450098585-3129-2-git-send-email-ranjit.waghmode@xilinx.com \
    --to=ranjit.waghmode@xilinx.com \
    --cc=afd@ti.com \
    --cc=beanhuo@micron.com \
    --cc=broonie@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=furquan@google.com \
    --cc=geert+renesas@glider.be \
    --cc=harinik@xilinx.com \
    --cc=jic23@kernel.org \
    --cc=jteki@openedev.com \
    --cc=juhosg@openwrt.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=michal.simek@xilinx.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=punnaia@xilinx.com \
    --cc=ran27jit@gmail.com \
    --cc=sean.nyekjaer@prevas.dk \
    --cc=soren.brinkmann@xilinx.com \
    --cc=swarren@nvidia.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).