From: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Subject: [PATCH 3/3] spi: rockchip: add debug interface support
Date: Mon, 15 Feb 2016 16:28:22 +0800 [thread overview]
Message-ID: <1455524902-2780-1-git-send-email-shawn.lin@rock-chips.com> (raw)
In-Reply-To: <1455524848-2646-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Add debugfs support for user to debug rockchip spi
problems.
Signed-off-by: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
---
drivers/spi/spi-rockchip.c | 79 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 79 insertions(+)
diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index 7cb1b2d..e858393 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -28,6 +28,10 @@
#include <linux/io.h>
#include <linux/dmaengine.h>
+#ifdef CONFIG_DEBUG_FS
+#include <linux/debugfs.h>
+#endif
+
#define DRIVER_NAME "rockchip-spi"
/* SPI register offsets */
@@ -199,8 +203,81 @@ struct rockchip_spi {
struct sg_table rx_sg;
struct rockchip_spi_dma_data dma_rx;
struct rockchip_spi_dma_data dma_tx;
+
+ #ifdef CONFIG_DEBUG_FS
+ struct dentry *debugfs;
+ #endif
+};
+
+#ifdef CONFIG_DEBUG_FS
+static int rockchip_spi_dbg_show(struct seq_file *s, void *v)
+{
+ struct rockchip_spi *rs = s->private;
+
+ seq_printf(s, "CTRLR0:\t0x%08x\n",
+ readl_relaxed(rs->regs + ROCKCHIP_SPI_CTRLR0));
+ seq_printf(s, "CTRLR1:\t0x%08x\n",
+ readl_relaxed(rs->regs + ROCKCHIP_SPI_CTRLR1));
+ seq_printf(s, "BAUDR:\t0x%08x\n",
+ readl_relaxed(rs->regs + ROCKCHIP_SPI_BAUDR));
+ seq_printf(s, "TXFTLR:\t0x%08x\n",
+ readl_relaxed(rs->regs + ROCKCHIP_SPI_TXFTLR));
+ seq_printf(s, "RXFTLR:\t0x%08x\n",
+ readl_relaxed(rs->regs + ROCKCHIP_SPI_RXFTLR));
+ seq_printf(s, "SR:\t0x%08x\n",
+ readl_relaxed(rs->regs + ROCKCHIP_SPI_SR));
+ seq_printf(s, "ISR:\t0x%08x\n",
+ readl_relaxed(rs->regs + ROCKCHIP_SPI_ISR));
+ seq_printf(s, "DMACR:\t0x%08x\n",
+ readl_relaxed(rs->regs + ROCKCHIP_SPI_DMACR));
+ seq_printf(s, "rs->state:\t0x%08x\n", rs->state);
+ seq_printf(s, "rs->speed:\t0x%08x\n", rs->speed);
+ seq_printf(s, "rs->tmode:\t0x%08x\n", rs->tmode);
+ seq_printf(s, "rs->mode:\t0x%08x\n", rs->mode);
+
+ return 0;
+}
+
+static int rockchip_spi_dbg_open(struct inode *inode, struct file *file)
+{
+ return single_open(file, rockchip_spi_dbg_show, inode->i_private);
+}
+
+static const struct file_operations rockchip_spi_dbg_ops = {
+ .owner = THIS_MODULE,
+ .open = rockchip_spi_dbg_open,
+ .read = seq_read,
+ .llseek = seq_lseek,
+ .release = single_release,
};
+static int rockchip_spi_debugfs_init(struct rockchip_spi *rs)
+{
+ rs->debugfs = debugfs_create_dir("rockchip_spi", NULL);
+ if (!rs->debugfs)
+ return -ENOMEM;
+
+ debugfs_create_file("regs", S_IFREG | S_IRUGO,
+ rs->debugfs, (void *)rs, &rockchip_spi_dbg_ops);
+ return 0;
+}
+
+static void rockchip_spi_debugfs_remove(struct rockchip_spi *rs)
+{
+ debugfs_remove_recursive(rs->debugfs);
+}
+#else
+static inline int rockchip_spi_debugfs_init(struct rockchip_spi *rs)
+{
+ return 0;
+}
+
+static inline void rockchip_spi_debugfs_remove(struct rockchip_spi *rs)
+{
+}
+#endif /* CONFIG_DEBUG_FS */
+
+
static inline void spi_enable_chip(struct rockchip_spi *rs, int enable)
{
writel_relaxed((enable ? 1 : 0), rs->regs + ROCKCHIP_SPI_SSIENR);
@@ -746,6 +823,7 @@ static int rockchip_spi_probe(struct platform_device *pdev)
goto err_register_master;
}
+ rockchip_spi_debugfs_init(rs);
return 0;
err_register_master:
@@ -770,6 +848,7 @@ static int rockchip_spi_remove(struct platform_device *pdev)
struct rockchip_spi *rs = spi_master_get_devdata(master);
pm_runtime_disable(&pdev->dev);
+ rockchip_spi_debugfs_remove(rs);
clk_disable_unprepare(rs->spiclk);
clk_disable_unprepare(rs->apb_pclk);
--
2.3.7
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-15 8:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 8:27 [PATCH 0/3] Some rockchip_spi fixes and debug support Shawn Lin
2016-02-15 8:27 ` [PATCH 1/3] spi: rockchip: disable runtime pm when in err case Shawn Lin
[not found] ` <1455524878-2696-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-02-15 12:28 ` Applied "spi: rockchip: disable runtime pm when in err case" to the spi tree Mark Brown
2016-02-15 8:28 ` [PATCH 2/3] spi: rockchip: add missing spi_master_put Shawn Lin
[not found] ` <1455524892-2739-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-02-15 12:28 ` Applied "spi: rockchip: add missing spi_master_put" to the spi tree Mark Brown
[not found] ` <1455524848-2646-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-02-15 8:28 ` Shawn Lin [this message]
2016-02-15 17:26 ` [PATCH 3/3] spi: rockchip: add debug interface support Mark Brown
[not found] ` <20160215172632.GQ18988-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-02-16 1:32 ` Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455524902-2780-1-git-send-email-shawn.lin@rock-chips.com \
--to=shawn.lin-tnx95d0mmh7dzftrwevzcw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).