linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Anton Bondarenko
	<anton.bondarenko.sama-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Subject: [PATCH 13/13] ARM: dts: imx6: Use correct SDMA script for SPI cores
Date: Wed, 17 Feb 2016 14:28:59 +0100	[thread overview]
Message-ID: <1455715739-25161-14-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1455715739-25161-1-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

According to the reference manual the shp_2_mcu / mcu_2_shp
scripts must be used for devices connected through the SPBA.

This fixes an issue we saw with DMA transfers from SPI NOR Flashes.
Sometimes the SPI controller RX FIFO was not empty after a DMA
transfer and the driver got stuck in the next PIO transfer when
it read one word more than expected.

Signed-off-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
 arch/arm/boot/dts/imx6qdl.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index 4f6ae92..06d2c4e 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -261,7 +261,7 @@
 					clocks = <&clks IMX6QDL_CLK_ECSPI1>,
 						 <&clks IMX6QDL_CLK_ECSPI1>;
 					clock-names = "ipg", "per";
-					dmas = <&sdma 3 7 1>, <&sdma 4 7 2>;
+					dmas = <&sdma 3 8 1>, <&sdma 4 8 2>;
 					dma-names = "rx", "tx";
 					status = "disabled";
 				};
@@ -275,7 +275,7 @@
 					clocks = <&clks IMX6QDL_CLK_ECSPI2>,
 						 <&clks IMX6QDL_CLK_ECSPI2>;
 					clock-names = "ipg", "per";
-					dmas = <&sdma 5 7 1>, <&sdma 6 7 2>;
+					dmas = <&sdma 5 8 1>, <&sdma 6 8 2>;
 					dma-names = "rx", "tx";
 					status = "disabled";
 				};
@@ -289,7 +289,7 @@
 					clocks = <&clks IMX6QDL_CLK_ECSPI3>,
 						 <&clks IMX6QDL_CLK_ECSPI3>;
 					clock-names = "ipg", "per";
-					dmas = <&sdma 7 7 1>, <&sdma 8 7 2>;
+					dmas = <&sdma 7 8 1>, <&sdma 8 8 2>;
 					dma-names = "rx", "tx";
 					status = "disabled";
 				};
@@ -303,7 +303,7 @@
 					clocks = <&clks IMX6QDL_CLK_ECSPI4>,
 						 <&clks IMX6QDL_CLK_ECSPI4>;
 					clock-names = "ipg", "per";
-					dmas = <&sdma 9 7 1>, <&sdma 10 7 2>;
+					dmas = <&sdma 9 8 1>, <&sdma 10 8 2>;
 					dma-names = "rx", "tx";
 					status = "disabled";
 				};
-- 
2.7.0

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-02-17 13:28 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17 13:28 [PATCH] i.MX SPI DMA cleanup Sascha Hauer
     [not found] ` <1455715739-25161-1-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-02-17 13:28   ` [PATCH 01/13] spi: imx: allow only WML aligned transfers to use DMA Sascha Hauer
     [not found]     ` <1455715739-25161-2-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-02-17 14:16       ` Mark Brown
     [not found]         ` <20160217141619.GR7544-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-02-17 15:01           ` Sascha Hauer
     [not found]             ` <20160217150146.GC3939-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-02-17 16:05               ` Mark Brown
2016-02-17 19:13       ` Applied "spi: imx: allow only WML aligned transfers to use DMA" to the spi tree Mark Brown
2016-02-17 13:28   ` [PATCH 02/13] spi: imx: use proper dev_* functions for driver messages Sascha Hauer
     [not found]     ` <1455715739-25161-3-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-02-17 19:13       ` Applied "spi: imx: use proper dev_* functions for driver messages" to the spi tree Mark Brown
2016-02-17 13:28   ` [PATCH 03/13] spi: imx: replace fixed timeout with calculated Sascha Hauer
     [not found]     ` <1455715739-25161-4-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-02-17 14:22       ` Mark Brown
2016-02-20 18:11       ` Applied "spi: imx: replace fixed timeout with calculated" to the spi tree Mark Brown
2016-02-17 13:28   ` [PATCH 04/13] spi: imx: drop fallback to PIO Sascha Hauer
2016-02-17 13:28   ` [PATCH 05/13] spi: imx: initialize usedma earlier Sascha Hauer
     [not found]     ` <1455715739-25161-6-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-02-26  2:48       ` Applied "spi: imx: initialize usedma earlier" to the spi tree Mark Brown
2016-02-17 13:28   ` [PATCH 06/13] spi: imx: drop unnecessary read/modify/write Sascha Hauer
     [not found]     ` <1455715739-25161-7-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-02-26  2:48       ` Applied "spi: imx: drop unnecessary read/modify/write" to the spi tree Mark Brown
2016-02-17 13:28   ` [PATCH 07/13] spi: imx: drop unncessary dma_is_inited variable Sascha Hauer
     [not found]     ` <1455715739-25161-8-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-02-26  2:47       ` Applied "spi: imx: drop unncessary dma_is_inited variable" to the spi tree Mark Brown
2016-02-17 13:28   ` [PATCH 08/13] spi: imx: add support for all SPI word width for DMA Sascha Hauer
     [not found]     ` <1455715739-25161-9-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-02-26  2:47       ` Applied "spi: imx: add support for all SPI word width for DMA" to the spi tree Mark Brown
2016-02-17 13:28   ` [PATCH 09/13] spi: imx: remove unnecessary bit clearing in mx51_ecspi_config Sascha Hauer
     [not found]     ` <1455715739-25161-10-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-02-26  2:47       ` Applied "spi: imx: remove unnecessary bit clearing in mx51_ecspi_config" to the spi tree Mark Brown
2016-02-17 13:28   ` [PATCH 10/13] spi: imx: make some register defines simpler Sascha Hauer
     [not found]     ` <1455715739-25161-11-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-02-26  2:47       ` Applied "spi: imx: make some register defines simpler" to the spi tree Mark Brown
2016-02-17 13:28   ` [PATCH 11/13] spi: imx: set MX51_ECSPI_CTRL_SMC bit in setup function Sascha Hauer
     [not found]     ` <1455715739-25161-12-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-02-26  2:47       ` Applied "spi: imx: set MX51_ECSPI_CTRL_SMC bit in setup function" to the spi tree Mark Brown
2016-02-17 13:28   ` [PATCH 12/13] spi: imx: drop bogus tests for rx/tx bufs in DMA transfer Sascha Hauer
2016-02-17 13:28   ` Sascha Hauer [this message]
2016-02-17 13:42   ` [PATCH] i.MX SPI DMA cleanup Dirk Behme
     [not found]     ` <56C478C9.6050706-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
2016-02-17 13:54       ` Sascha Hauer
     [not found]         ` <20160217135441.GA3939-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-02-17 14:10           ` Dirk Behme
     [not found]             ` <56C47F64.1080706-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
2016-02-17 14:59               ` Sascha Hauer
     [not found]                 ` <20160217145944.GB3939-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-02-17 15:33                   ` Dirk Behme
     [not found]                     ` <56C492DB.6000405-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
2016-02-17 15:40                       ` Fabio Estevam
2016-02-18 14:47   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455715739-25161-14-git-send-email-s.hauer@pengutronix.de \
    --to=s.hauer-bicnvbalz9megne8c9+irq@public.gmane.org \
    --cc=anton.bondarenko.sama-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).