linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
To: <linux-spi@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <broonie@kernel.org>,
	Shubhrajyoti Datta <shubhraj@xilinx.com>
Subject: [PATCH 7/7] spi: cadence: Return the error code for cdns_spi_suspend and cdns_spi_resume
Date: Tue, 5 Apr 2016 23:37:54 +0530	[thread overview]
Message-ID: <1459879674-13012-7-git-send-email-shubhraj@xilinx.com> (raw)
In-Reply-To: <1459879674-13012-1-git-send-email-shubhraj@xilinx.com>

Return the error code for cdns_spi_suspend and cdns_spi_resume.
Also fixes a comment where which claims that the error code is
returned.

Signed-off-by: Shubhrajyoti Datta <shubhraj@xilinx.com>
---
 drivers/spi/spi-cadence.c |   10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c
index d0cdd18..07481e1 100644
--- a/drivers/spi/spi-cadence.c
+++ b/drivers/spi/spi-cadence.c
@@ -615,16 +615,14 @@ static int cdns_spi_remove(struct platform_device *pdev)
  * This function disables the SPI controller and
  * changes the driver state to "suspend"
  *
- * Return:	Always 0
+ * Return:	0 on success and error value on error
  */
 static int __maybe_unused cdns_spi_suspend(struct device *dev)
 {
 	struct platform_device *pdev = to_platform_device(dev);
 	struct spi_master *master = platform_get_drvdata(pdev);
 
-	spi_master_suspend(master);
-
-	return 0;
+	return spi_master_suspend(master);
 }
 
 /**
@@ -640,9 +638,7 @@ static int __maybe_unused cdns_spi_resume(struct device *dev)
 	struct platform_device *pdev = to_platform_device(dev);
 	struct spi_master *master = platform_get_drvdata(pdev);
 
-	spi_master_resume(master);
-
-	return 0;
+	return spi_master_resume(master);
 }
 
 /**
-- 
1.7.1

  parent reply	other threads:[~2016-04-05 18:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05 18:07 [PATCH 1/7] spi: cadence: Fix a check patch warning Shubhrajyoti Datta
2016-04-05 18:07 ` [PATCH 2/7] spi: cadence: Remove _MASK and _OFFSET suffix Shubhrajyoti Datta
     [not found]   ` <1459879674-13012-2-git-send-email-shubhraj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2016-04-05 18:51     ` Applied "spi: cadence: Remove _MASK and _OFFSET suffix" to the spi tree Mark Brown
     [not found] ` <1459879674-13012-1-git-send-email-shubhraj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2016-04-05 18:07   ` [PATCH 3/7] spi: cadence: Fix probe error handling Shubhrajyoti Datta
     [not found]     ` <1459879674-13012-3-git-send-email-shubhraj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2016-04-05 18:51       ` Applied "spi: cadence: Fix probe error handling" to the spi tree Mark Brown
2016-04-05 18:07   ` [PATCH 4/7] spi: cadance: Fix the Documentation Shubhrajyoti Datta
     [not found]     ` <1459879674-13012-4-git-send-email-shubhraj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2016-04-05 18:51       ` Applied "spi: cadance: Fix the Documentation" to the spi tree Mark Brown
2016-04-05 18:07   ` [PATCH 6/7] spi: cadence: Remove the clock enable and disable from suspend and resume Shubhrajyoti Datta
     [not found]     ` <1459879674-13012-6-git-send-email-shubhraj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2016-04-05 18:51       ` Applied "spi: cadence: Remove the clock enable and disable from suspend and resume" to the spi tree Mark Brown
2016-04-05 18:51   ` Applied "spi: cadence: Fix a check patch warning" " Mark Brown
2016-04-05 18:07 ` [PATCH 5/7] spi: cadence: Runtime pm adaptation Shubhrajyoti Datta
     [not found]   ` <1459879674-13012-5-git-send-email-shubhraj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2016-04-05 18:51     ` Applied "spi: cadence: Runtime pm adaptation" to the spi tree Mark Brown
2016-04-05 18:07 ` Shubhrajyoti Datta [this message]
     [not found]   ` <1459879674-13012-7-git-send-email-shubhraj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2016-04-05 18:51     ` Applied "spi: cadence: Return the error code for cdns_spi_suspend and cdns_spi_resume" " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459879674-13012-7-git-send-email-shubhraj@xilinx.com \
    --to=shubhrajyoti.datta@xilinx.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=shubhraj@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).