linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: P L Sai Krishna <lakshmi.sai.krishna.potthuri@xilinx.com>
To: "Michal Simek" <michal.simek@xilinx.com>,
	"Soren Brinkmann" <soren.brinkmann@xilinx.com>,
	"David Woodhouse" <dwmw2@infradead.org>,
	"Brian Norris" <computersforpeace@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Javier Martinez Canillas" <javier@osg.samsung.com>,
	"Boris Brezillon" <boris.brezillon@free-electrons.com>,
	"Stephen Warren" <swarren@nvidia.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Andrew F. Davis" <afd@ti.com>, "Marek Vasut" <marex@denx.de>,
	"Jagan Teki" <jteki@openedev.com>,
	"Rafał Miłecki" <zajec5@gmail.com>
Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<linux-spi@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	"Harini Katakam" <harinik@xilinx.com>,
	Punnaiah Choudary Kalluri <punnaia@xilinx.com>,
	Anirudha Sarangi <anirudh@xilinx.com>,
	P L Sai Krishna <lakshmis@xilinx.com>
Subject: [LINUX PATCH v2 1/3] spi: Added dummy_cycle entry in the spi_transfer structure.
Date: Thu, 7 Apr 2016 20:09:27 +0530	[thread overview]
Message-ID: <1460039969-9835-1-git-send-email-lakshmis@xilinx.com> (raw)

This patch adds dummy_cycles entry in the spi_transfer structure.
len field in the transfer structure contains dummy bytes along with
actual data bytes, controllers which requires dummy bytes use len
field and simply Ignore the dummy_cycles field. Controllers which
expects dummy cycles won't work directly by using len field because
host driver doesn't know that len field of a particular transfer
includes dummy bytes or not (and also number of dummy bytes included
in len field). In such cases host driver use this dummy_cycles field
to identify the number of dummy cycles and based on that it will send
the required number of dummy cycles.

Signed-off-by: P L Sai Krishna <lakshmis@xilinx.com>
---
v2: 
 - Changed the structure member name from dummy to dummy_cycles.
 - Updated the documentation of dummy_cycles.
 - m25p80 changes split into another patch.

 include/linux/spi/spi.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h
index 857a9a1..63135b3 100644
--- a/include/linux/spi/spi.h
+++ b/include/linux/spi/spi.h
@@ -664,6 +664,9 @@ extern void spi_res_release(struct spi_master *master,
  * @len: size of rx and tx buffers (in bytes)
  * @speed_hz: Select a speed other than the device default for this
  *      transfer. If 0 the default (from @spi_device) is used.
+ * @dummy_cycles: number of dummy cycles. If host controller requires
+ * 	dummy cycles rather than dummy bytes which send along with Cmd
+ *	and address then this dummy_cycles is used.
  * @bits_per_word: select a bits_per_word other than the device default
  *      for this transfer. If 0 the default (from @spi_device) is used.
  * @cs_change: affects chipselect after this transfer completes
@@ -752,6 +755,7 @@ struct spi_transfer {
 	u8		bits_per_word;
 	u16		delay_usecs;
 	u32		speed_hz;
+	u32		dummy_cycles;
 
 	struct list_head transfer_list;
 };
-- 
2.1.2

             reply	other threads:[~2016-04-07 14:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-07 14:39 P L Sai Krishna [this message]
2016-04-07 14:39 ` [LINUX PATCH v2 2/3] mtd:m25p80: Assigned number of dummy cycles to dummy_cycles P L Sai Krishna
     [not found]   ` <1460039969-9835-2-git-send-email-lakshmis-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2016-04-07 14:59     ` kbuild test robot
     [not found] ` <1460039969-9835-1-git-send-email-lakshmis-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2016-04-07 14:39   ` [LINUX PATCH v2 3/3] spi:zynqmp:gqspi: Added separate dummy entry P L Sai Krishna
2016-04-07 15:02   ` [LINUX PATCH v2 1/3] spi: Added dummy_cycle entry in the spi_transfer structure Cyrille Pitchen
     [not found]     ` <57067694.8030806-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2016-04-13  5:21       ` Lakshmi Sai Krishna Potthuri
     [not found]         ` <4FF8F58FAA9D5D4193D4E554E4352C5902C720DE-4lKfpRxZ5ekkx2a1wsGfbYg+Gb3gawCHQz34XiSyOiE@public.gmane.org>
2016-04-14  8:06           ` Cyrille Pitchen
     [not found]             ` <570F4F9F.3090605-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2016-04-14  8:57               ` Mark Brown
     [not found]                 ` <20160414085707.GE18024-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-04-14 15:23                   ` Cyrille Pitchen
2016-04-12  6:10   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460039969-9835-1-git-send-email-lakshmis@xilinx.com \
    --to=lakshmi.sai.krishna.potthuri@xilinx.com \
    --cc=afd@ti.com \
    --cc=anirudh@xilinx.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=broonie@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=geert+renesas@glider.be \
    --cc=harinik@xilinx.com \
    --cc=javier@osg.samsung.com \
    --cc=jteki@openedev.com \
    --cc=lakshmis@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=michal.simek@xilinx.com \
    --cc=punnaia@xilinx.com \
    --cc=soren.brinkmann@xilinx.com \
    --cc=swarren@nvidia.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).