From: Ben Hutchings <ben.hutchings-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
CT kernel
<linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org>
Subject: Re: [PATCH 1/2] spi: spi-ti-qspi: Fix FLEN and WLEN settings if bits_per_word is overridden
Date: Tue, 12 Apr 2016 12:07:29 +0100 [thread overview]
Message-ID: <1460459249.32355.4.camel@codethink.co.uk> (raw)
In-Reply-To: <20160412013014.GR3351-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Tue, 2016-04-12 at 02:30 +0100, Mark Brown wrote:
> On Tue, Apr 05, 2016 at 08:45:28PM +0100, Ben Hutchings wrote:
>
> > + frame_length = 0;
> > + list_for_each_entry(t, &m->transfers, transfer_list)
> > + frame_length += t->len / (t->bits_per_word >> 3);
> > + frame_length = min_t(unsigned int, frame_length, QSPI_FRAME);
> >
>
> This doesn't seem obviously correct - what exactly is the frame length
> here and why doesn't it change per transfer like the word length does?
> There's nothing in the changelog about this.
The frame_length is the number of words in the frame, as it was before
this change. Shall I insert a preparatory patch to give the variables
better names?
Ben.
--
Ben Hutchings
Software Developer, Codethink Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-04-12 11:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 19:45 [PATCH 1/2] spi: spi-ti-qspi: Fix FLEN and WLEN settings if bits_per_word is overridden Ben Hutchings
[not found] ` <1459885528.26669.5.camel-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2016-04-05 19:48 ` [PATCH 2/2] spi: spi-ti-qspi: Handle truncated frames properly Ben Hutchings
[not found] ` <1459885728.26669.7.camel-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2016-04-12 1:58 ` Mark Brown
[not found] ` <20160412015809.GS3351-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-04-12 11:09 ` Ben Hutchings
[not found] ` <1460459364.32355.6.camel-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2016-04-13 6:55 ` Mark Brown
2016-04-12 1:30 ` [PATCH 1/2] spi: spi-ti-qspi: Fix FLEN and WLEN settings if bits_per_word is overridden Mark Brown
[not found] ` <20160412013014.GR3351-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-04-12 11:07 ` Ben Hutchings [this message]
[not found] ` <1460459249.32355.4.camel-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2016-04-13 6:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460459249.32355.4.camel@codethink.co.uk \
--to=ben.hutchings-4ydnlxn2s6swdatgbsphta@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).