From: Thomas Perrot <thomas.perrot-cVvwS2TCF4I@public.gmane.org>
To: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
Thomas Perrot <thomas.perrot-cVvwS2TCF4I@public.gmane.org>
Subject: [PATCH] spi: fix __spi_pump_messages deadlock
Date: Fri, 13 May 2016 14:58:32 +0200 [thread overview]
Message-ID: <1463144312-23998-1-git-send-email-thomas.perrot@tupi.fr> (raw)
The lock on the spi bus is never release at the end of call of the function
__spi_pump_messages.
Signed-off-by: Thomas Perrot <thomas.perrot-cVvwS2TCF4I@public.gmane.org>
---
drivers/spi/spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 0239b45..785080a 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -1192,7 +1192,7 @@ static void __spi_pump_messages(struct spi_master *master, bool in_kthread,
}
out:
- if (!bus_locked)
+ if (bus_locked)
mutex_unlock(&master->bus_lock_mutex);
/* Prod the scheduler in case transfer_one() was busy waiting */
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2016-05-13 12:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 12:58 Thomas Perrot [this message]
[not found] ` <1463144312-23998-1-git-send-email-thomas.perrot-cVvwS2TCF4I@public.gmane.org>
2016-05-13 13:38 ` [PATCH] spi: fix __spi_pump_messages deadlock Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2016-05-13 9:31 Thomas Perrot
[not found] ` <1463131892-5392-1-git-send-email-thomas.perrot-cVvwS2TCF4I@public.gmane.org>
2016-05-13 10:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463144312-23998-1-git-send-email-thomas.perrot@tupi.fr \
--to=thomas.perrot-cvvws2tcf4i@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).