linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org, "Mark Brown" <broonie@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] spi: add DT binding for clps711x SPI
Date: Wed, 13 Jul 2016 11:20:00 +0300	[thread overview]
Message-ID: <1468398000.319627182@f165.i.mail.ru> (raw)
In-Reply-To: <9132787.CoNHcRuYpT@wuerfel>

>Среда, 13 июля 2016, 11:13 +03:00 от Arnd Bergmann <arnd@arndb.de>:
>
>On Tuesday, July 12, 2016 3:49:47 PM CEST Rob Herring wrote:
>> On Thu, Jul 07, 2016 at 11:49:46AM +0200, Arnd Bergmann wrote:
>> > +
>> > +An additional register is present in the system controller,
>> > +which is assumed to be in the same device tree, with and marked
>> > +as compatible with "cirrus,ep7209-syscon3".
>> > +
>> > +Example:
>> > +
>> > +spi@80000500 {
>> > +     #address-cells = <1>;
>> > +     #size-cells = <0>;
>> > +     compatible = "cirrus,ep7209-spi";
>> > +     reg = <0x80000500 0x4>;
>> > +     interrupts = <15>;
>> > +     clocks = <&clks CLPS711X_CLK_SPI>;
>> > +     status = "disabled";
>> > +};
>> > +
>> > +syscon3: syscon@80002200 {
>> 
>> This looks like it shouldn't be here.
>
>The label, or the entire node?

I think that the whole syscon3 node is redundant.

---

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2016-07-13  8:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07  9:49 [PATCH v2 1/2] spi: clps711x: Driver refactor Arnd Bergmann
     [not found] ` <20160707094952.4111577-1-arnd-r2nGTMty4D4@public.gmane.org>
2016-07-07  9:49   ` [PATCH v2 2/2] spi: add DT binding for clps711x SPI Arnd Bergmann
2016-07-12 20:49     ` Rob Herring
2016-07-13  8:13       ` Arnd Bergmann
2016-07-13  8:20         ` Alexander Shiyan [this message]
     [not found]           ` <1468398000.319627182-MSam/alRxCtsdVUOrk1QfQ@public.gmane.org>
2016-07-13  8:32             ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468398000.319627182@f165.i.mail.ru \
    --to=shc_work@mail.ru \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).