* [v.1] spi : spi-fsl :- Error check if cpm_muram_alloc fails and return
@ 2016-08-10 17:34 Arvind Yadav
0 siblings, 0 replies; only message in thread
From: Arvind Yadav @ 2016-08-10 17:34 UTC (permalink / raw)
To: broonie-DgEjT+Ai2ygdnm+yROfE0A,
galak-XVmvHMARGAS8U2dJNN8I7kEOCMrvLtNR
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Arvind Yadav
cpm_muram_alloc can fail so the returned value should be checked.
Signed-off-by: Arvind Yadav <arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/spi/spi-fsl-cpm.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/spi/spi-fsl-cpm.c b/drivers/spi/spi-fsl-cpm.c
index 8f7b26e..1362e2d 100644
--- a/drivers/spi/spi-fsl-cpm.c
+++ b/drivers/spi/spi-fsl-cpm.c
@@ -258,6 +258,9 @@ static unsigned long fsl_spi_cpm_get_pram(struct mpc8xxx_spi *mspi)
/* QE but with a dynamic pram location? */
if (mspi->flags & SPI_QE) {
pram_ofs = cpm_muram_alloc(SPI_PRAM_SIZE, 64);
+ if (IS_ERR_VALUE(pram_ofs))
+ return pram_ofs;
+
qe_issue_cmd(QE_ASSIGN_PAGE_TO_DEVICE, mspi->subblock,
QE_CR_PROTOCOL_UNSPECIFIED, pram_ofs);
return pram_ofs;
@@ -269,9 +272,13 @@ static unsigned long fsl_spi_cpm_get_pram(struct mpc8xxx_spi *mspi)
if (mspi->flags & SPI_CPM2) {
pram_ofs = cpm_muram_alloc(SPI_PRAM_SIZE, 64);
+ if (IS_ERR_VALUE(pram_ofs))
+ goto error_pram;
+
out_be16(spi_base, pram_ofs);
}
+error_pram:
iounmap(spi_base);
return pram_ofs;
}
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-08-10 17:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-10 17:34 [v.1] spi : spi-fsl :- Error check if cpm_muram_alloc fails and return Arvind Yadav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).