From: Gao Pan <pandy.gao-3arQi8VN3Tc@public.gmane.org>
To: <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<pandy.gao-3arQi8VN3Tc@public.gmane.org>
Subject: [Patch V1 2/2] spi: fsl-lpspi: quit reading rx fifo under error condition
Date: Fri, 2 Dec 2016 11:50:01 +0800 [thread overview]
Message-ID: <1480650601-12810-2-git-send-email-pandy.gao@nxp.com> (raw)
In-Reply-To: <1480650601-12810-1-git-send-email-pandy.gao-3arQi8VN3Tc@public.gmane.org>
In case that error occurs during waiting for txfifo empty, it is
not necessary to read rx fifo. It's better to return directly.
Signed-off-by: Gao Pan <pandy.gao-3arQi8VN3Tc@public.gmane.org>
---
drivers/spi/spi-fsl-lpspi.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c
index c4a4e262..52551f6 100644
--- a/drivers/spi/spi-fsl-lpspi.c
+++ b/drivers/spi/spi-fsl-lpspi.c
@@ -350,9 +350,12 @@ static int fsl_lpspi_transfer_one(struct spi_master *master,
}
ret = fsl_lpspi_txfifo_empty(fsl_lpspi);
+ if (ret)
+ return ret;
+
fsl_lpspi_read_rx_fifo(fsl_lpspi);
- return ret;
+ return 0;
}
static int fsl_lpspi_transfer_one_msg(struct spi_master *master,
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-12-02 3:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 3:50 [Patch V1 1/2] spi: fsl-lpspi: use GPL as module license Gao Pan
[not found] ` <1480650601-12810-1-git-send-email-pandy.gao-3arQi8VN3Tc@public.gmane.org>
2016-12-02 3:50 ` Gao Pan [this message]
[not found] ` <1480650601-12810-2-git-send-email-pandy.gao-3arQi8VN3Tc@public.gmane.org>
2016-12-05 12:10 ` Applied "spi: fsl-lpspi: quit reading rx fifo under error condition" to the spi tree Mark Brown
2016-12-05 12:10 ` Applied "spi: fsl-lpspi: use GPL as module license" " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480650601-12810-2-git-send-email-pandy.gao@nxp.com \
--to=pandy.gao-3arqi8vn3tc@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).