* [Patch V1 1/2] spi: fsl-lpspi: use GPL as module license @ 2016-12-02 3:50 Gao Pan [not found] ` <1480650601-12810-1-git-send-email-pandy.gao-3arQi8VN3Tc@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Gao Pan @ 2016-12-02 3:50 UTC (permalink / raw) To: broonie-DgEjT+Ai2ygdnm+yROfE0A Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, pandy.gao-3arQi8VN3Tc At the beginning of lpspi driver, it is claimed that the dirver is under the terms of the GNU General Public License, either version 2 of the License. While at the end I only declared GPL V2. This patch make the license consistent. Signed-off-by: Gao Pan <pandy.gao-3arQi8VN3Tc@public.gmane.org> --- drivers/spi/spi-fsl-lpspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 71eca6e..c4a4e262 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -519,4 +519,4 @@ static int fsl_lpspi_remove(struct platform_device *pdev) MODULE_DESCRIPTION("LPSPI Master Controller driver"); MODULE_AUTHOR("Gao Pan <pandy.gao-3arQi8VN3Tc@public.gmane.org>"); -MODULE_LICENSE("GPL v2"); +MODULE_LICENSE("GPL"); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <1480650601-12810-1-git-send-email-pandy.gao-3arQi8VN3Tc@public.gmane.org>]
* [Patch V1 2/2] spi: fsl-lpspi: quit reading rx fifo under error condition [not found] ` <1480650601-12810-1-git-send-email-pandy.gao-3arQi8VN3Tc@public.gmane.org> @ 2016-12-02 3:50 ` Gao Pan [not found] ` <1480650601-12810-2-git-send-email-pandy.gao-3arQi8VN3Tc@public.gmane.org> 2016-12-05 12:10 ` Applied "spi: fsl-lpspi: use GPL as module license" " Mark Brown 1 sibling, 1 reply; 4+ messages in thread From: Gao Pan @ 2016-12-02 3:50 UTC (permalink / raw) To: broonie-DgEjT+Ai2ygdnm+yROfE0A Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, pandy.gao-3arQi8VN3Tc In case that error occurs during waiting for txfifo empty, it is not necessary to read rx fifo. It's better to return directly. Signed-off-by: Gao Pan <pandy.gao-3arQi8VN3Tc@public.gmane.org> --- drivers/spi/spi-fsl-lpspi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index c4a4e262..52551f6 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -350,9 +350,12 @@ static int fsl_lpspi_transfer_one(struct spi_master *master, } ret = fsl_lpspi_txfifo_empty(fsl_lpspi); + if (ret) + return ret; + fsl_lpspi_read_rx_fifo(fsl_lpspi); - return ret; + return 0; } static int fsl_lpspi_transfer_one_msg(struct spi_master *master, -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <1480650601-12810-2-git-send-email-pandy.gao-3arQi8VN3Tc@public.gmane.org>]
* Applied "spi: fsl-lpspi: quit reading rx fifo under error condition" to the spi tree [not found] ` <1480650601-12810-2-git-send-email-pandy.gao-3arQi8VN3Tc@public.gmane.org> @ 2016-12-05 12:10 ` Mark Brown 0 siblings, 0 replies; 4+ messages in thread From: Mark Brown @ 2016-12-05 12:10 UTC (permalink / raw) To: Gao Pan Cc: Mark Brown, broonie-DgEjT+Ai2ygdnm+yROfE0A, linux-spi-u79uwXL29TY76Z2rM5mHXA, pandy.gao-3arQi8VN3Tc, linux-spi-u79uwXL29TY76Z2rM5mHXA The patch spi: fsl-lpspi: quit reading rx fifo under error condition has been applied to the spi tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From d989eed20791534dc624c7b29568b263c67a286f Mon Sep 17 00:00:00 2001 From: Gao Pan <pandy.gao-3arQi8VN3Tc@public.gmane.org> Date: Fri, 2 Dec 2016 11:50:01 +0800 Subject: [PATCH] spi: fsl-lpspi: quit reading rx fifo under error condition In case that error occurs during waiting for txfifo empty, it is not necessary to read rx fifo. It's better to return directly. Signed-off-by: Gao Pan <pandy.gao-3arQi8VN3Tc@public.gmane.org> Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> --- drivers/spi/spi-fsl-lpspi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index c4a4e2622a53..52551f6d0c7d 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -350,9 +350,12 @@ static int fsl_lpspi_transfer_one(struct spi_master *master, } ret = fsl_lpspi_txfifo_empty(fsl_lpspi); + if (ret) + return ret; + fsl_lpspi_read_rx_fifo(fsl_lpspi); - return ret; + return 0; } static int fsl_lpspi_transfer_one_msg(struct spi_master *master, -- 2.10.2 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Applied "spi: fsl-lpspi: use GPL as module license" to the spi tree [not found] ` <1480650601-12810-1-git-send-email-pandy.gao-3arQi8VN3Tc@public.gmane.org> 2016-12-02 3:50 ` [Patch V1 2/2] spi: fsl-lpspi: quit reading rx fifo under error condition Gao Pan @ 2016-12-05 12:10 ` Mark Brown 1 sibling, 0 replies; 4+ messages in thread From: Mark Brown @ 2016-12-05 12:10 UTC (permalink / raw) To: Gao Pan Cc: Mark Brown, broonie-DgEjT+Ai2ygdnm+yROfE0A, linux-spi-u79uwXL29TY76Z2rM5mHXA, pandy.gao-3arQi8VN3Tc, linux-spi-u79uwXL29TY76Z2rM5mHXA The patch spi: fsl-lpspi: use GPL as module license has been applied to the spi tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From b6787b6807fb01b13f0f1a07cbb8eaf7853d1a6e Mon Sep 17 00:00:00 2001 From: Gao Pan <pandy.gao-3arQi8VN3Tc@public.gmane.org> Date: Fri, 2 Dec 2016 11:50:00 +0800 Subject: [PATCH] spi: fsl-lpspi: use GPL as module license At the beginning of lpspi driver, it is claimed that the dirver is under the terms of the GNU General Public License, either version 2 of the License. While at the end I only declared GPL V2. This patch make the license consistent. Signed-off-by: Gao Pan <pandy.gao-3arQi8VN3Tc@public.gmane.org> Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> --- drivers/spi/spi-fsl-lpspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 71eca6e3fe32..c4a4e2622a53 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -519,4 +519,4 @@ module_platform_driver(fsl_lpspi_driver); MODULE_DESCRIPTION("LPSPI Master Controller driver"); MODULE_AUTHOR("Gao Pan <pandy.gao-3arQi8VN3Tc@public.gmane.org>"); -MODULE_LICENSE("GPL v2"); +MODULE_LICENSE("GPL"); -- 2.10.2 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-05 12:10 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-12-02 3:50 [Patch V1 1/2] spi: fsl-lpspi: use GPL as module license Gao Pan [not found] ` <1480650601-12810-1-git-send-email-pandy.gao-3arQi8VN3Tc@public.gmane.org> 2016-12-02 3:50 ` [Patch V1 2/2] spi: fsl-lpspi: quit reading rx fifo under error condition Gao Pan [not found] ` <1480650601-12810-2-git-send-email-pandy.gao-3arQi8VN3Tc@public.gmane.org> 2016-12-05 12:10 ` Applied "spi: fsl-lpspi: quit reading rx fifo under error condition" to the spi tree Mark Brown 2016-12-05 12:10 ` Applied "spi: fsl-lpspi: use GPL as module license" " Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).