From: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
To: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Geert Uytterhoeven
<geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
Subject: [PATCH/RFC] signal: Export signal_wake_up_state() to modules
Date: Fri, 5 May 2017 11:49:11 +0200 [thread overview]
Message-ID: <1493977751-19340-1-git-send-email-geert+renesas@glider.be> (raw)
When using signal_wake_up() from a loadable kernel module:
ERROR: "signal_wake_up_state" [drivers/spi/spi-sh-msiof.ko] undefined!
Export signal_wake_up_state() to modules to fix this.
Reported-by: kbuild test robot <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
---
I'm using signal_wake_up() to abort a task blocked on
wait_for_completion_interruptible(), cfr. sh_msiof_slave_abort() in
"spi: sh-msiof: Add slave mode support"
(http://www.spinics.net/lists/devicetree/msg175575.html).
Is exporting signal_wake_up_state() an acceptable solution?
Alternatively, I can extract the code to abort an completion into a
generic abort_completion() function, and export that.
Or is there a better way to abort a completion?
Thanks!
---
kernel/signal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/signal.c b/kernel/signal.c
index 7e59ebc2c25e669e..f130598acd34f08b 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -660,6 +660,7 @@ void signal_wake_up_state(struct task_struct *t, unsigned int state)
if (!wake_up_state(t, state | TASK_INTERRUPTIBLE))
kick_process(t);
}
+EXPORT_SYMBOL_GPL(signal_wake_up_state);
/*
* Remove signals in mask from the pending set and queue.
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2017-05-05 9:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 9:49 Geert Uytterhoeven [this message]
[not found] ` <1493977751-19340-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2017-05-05 10:07 ` [PATCH/RFC] signal: Export signal_wake_up_state() to modules Christoph Hellwig
[not found] ` <20170505100729.GA21589-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-05-05 10:13 ` Geert Uytterhoeven
2017-05-05 11:08 ` Geert Uytterhoeven
[not found] ` <CAMuHMdVUymKQzt9Rk1mgXxJdVD1O8yFQ6CxFAZDiLRDM795-Ew-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-05 11:22 ` Christoph Hellwig
2017-05-05 11:35 ` Geert Uytterhoeven
2017-05-06 19:42 ` Oleg Nesterov
[not found] ` <20170506194256.GA21726-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-05-07 9:47 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493977751-19340-1-git-send-email-geert+renesas@glider.be \
--to=geert+renesas-gxvu3+zwzmszqb+pc5nmwq@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).