From: Leonard Crestez <leonard.crestez@nxp.com>
To: <jiada_wang@mentor.com>, <broonie@kernel.org>
Cc: <linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] spi: imx: fix issue when tx_buf or rx_buf is NULL
Date: Thu, 18 May 2017 13:08:34 +0300 [thread overview]
Message-ID: <1495102114.26925.20.camel@nxp.com> (raw)
In-Reply-To: <1495101672-3384-1-git-send-email-jiada_wang@mentor.com>
On Thu, 2017-05-18 at 03:01 -0700, jiada_wang@mentor.com wrote:
> From: Jiada Wang <jiada_wang@mentor.com>
>
> In case either transfer->tx_buf or transfer->rx_buf is NULL,
> manipulation of buffer in spi_imx_u32_swap_u[8|16]() will cause
> NULL pointer dereference crash.
>
> Add buffer check at very beginning of spi_imx_u32_swap_u[8|16](),
> to avoid such crash.
>
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
> Reported-by: Leonard Crestez <leonard.crestez@nxp.com>
Tested-by: Leonard Crestez <leonard.crestez@nxp.com>
next prev parent reply other threads:[~2017-05-18 10:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 10:01 [PATCH 1/1] spi: imx: fix issue when tx_buf or rx_buf is NULL jiada_wang-nmGgyN9QBj3QT0dZR+AlfA
2017-05-18 10:08 ` Leonard Crestez [this message]
[not found] ` <1495101672-3384-1-git-send-email-jiada_wang-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2017-05-19 12:45 ` Chris Ruehl
[not found] ` <94de6e6d-a2fa-6589-151b-660bbcb42773-CR359r9tUDPXPF5Rlphj1Q@public.gmane.org>
2017-05-19 13:15 ` Andy Shevchenko
2017-05-19 16:56 ` Mark Brown
2017-05-19 17:04 ` Applied "spi: imx: fix issue when tx_buf or rx_buf is NULL" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495102114.26925.20.camel@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=broonie@kernel.org \
--cc=jiada_wang@mentor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).