From: Varadarajan Narayanan <varada@codeaurora.org>
To: broonie@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
andy.gross@linaro.org, david.brown@linaro.org,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org
Cc: Varadarajan Narayanan <varada@codeaurora.org>
Subject: [PATCH v3 06/15] spi: qup: Fix error handling in spi_qup_prep_sg
Date: Tue, 20 Jun 2017 14:40:48 +0530 [thread overview]
Message-ID: <1497949857-1852-7-git-send-email-varada@codeaurora.org> (raw)
In-Reply-To: <1497949857-1852-1-git-send-email-varada@codeaurora.org>
Signed-off-by: Varadarajan Narayanan <varada@codeaurora.org>
---
drivers/spi/spi-qup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
index 0683e47..e2b4a50 100644
--- a/drivers/spi/spi-qup.c
+++ b/drivers/spi/spi-qup.c
@@ -310,8 +310,8 @@ static int spi_qup_prep_sg(struct spi_master *master, struct spi_transfer *xfer,
}
desc = dmaengine_prep_slave_sg(chan, sgl, nents, dir, flags);
- if (!desc)
- return -EINVAL;
+ if (IS_ERR_OR_NULL(desc))
+ return desc ? PTR_ERR(desc) : -EINVAL;
desc->callback = callback;
desc->callback_param = data;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2017-06-20 9:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 9:10 [PATCH v3 00/15] spi: qup: Fixes and add support for >64k transfers Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 01/15] spi: qup: Enable chip select support Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 02/15] spi: qup: Setup DMA mode correctly Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 03/15] spi: qup: Add completion structures for DMA Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 05/15] spi: qup: Place the QUP in run mode before DMA Varadarajan Narayanan
2017-06-20 9:10 ` Varadarajan Narayanan [this message]
2017-06-20 9:10 ` [PATCH v3 07/15] spi: qup: Fix transaction done signaling Varadarajan Narayanan
2017-08-08 11:18 ` Applied "spi: qup: Fix transaction done signaling" to the spi tree Mark Brown
2017-06-20 9:10 ` [PATCH v3 08/15] spi: qup: Do block sized read/write in block mode Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 09/15] spi: qup: refactor spi_qup_io_config into two functions Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 10/15] spi: qup: call io_config in mode specific function Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 11/15] spi: qup: allow block mode to generate multiple transactions Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 12/15] spi: qup: refactor spi_qup_prep_sg Varadarajan Narayanan
[not found] ` <1497949857-1852-1-git-send-email-varada-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-06-20 9:10 ` [PATCH v3 04/15] spi: qup: Add completion timeout Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 13/15] spi: qup: allow multiple DMA transactions per spi xfer Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 14/15] spi: qup: Ensure done detection Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 15/15] spi: qup: support for qup v1 dma Varadarajan Narayanan
2017-06-23 21:49 ` Rob Herring
2017-06-27 9:36 ` Varadarajan Narayanan
2017-06-28 6:47 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497949857-1852-7-git-send-email-varada@codeaurora.org \
--to=varada@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=broonie@kernel.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).