From: Trent Piepho <tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
To: "linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"julien.thierry-5wv7dgnIgG8@public.gmane.org"
<julien.thierry-5wv7dgnIgG8@public.gmane.org>
Cc: "fabio.estevam-3arQi8VN3Tc@public.gmane.org"
<fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
"shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"gerg-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org"
<gerg-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
"kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
<kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Subject: Re: [PATCH 3/4] spi: imx: Don't require platform data chipselect array
Date: Wed, 18 Oct 2017 17:30:10 +0000 [thread overview]
Message-ID: <1508347809.87493.2.camel@impinj.com> (raw)
In-Reply-To: <36d381de-ee3f-26d4-59c3-b9d361758ace-5wv7dgnIgG8@public.gmane.org>
On Wed, 2017-10-18 at 10:02 +0100, Julien Thierry wrote:
> > --- a/drivers/spi/spi-imx.c
> > +++ b/drivers/spi/spi-imx.c
> > @@ -1364,13 +1364,15 @@ static int spi_imx_probe(struct platform_device *pdev)
> >
> > if (mxc_platform_info) {
> > master->num_chipselect = mxc_platform_info->num_chipselect;
>
> nit:
> This is only useful when num_chipselect is non-zero (master's memory is
> zeroed on allocation). So maybe this could be simplified a bit more as:
>
> if (mxc_platform_info && mxc_platform_info->chipselect) {
> master->num_chipselect = mxc_platform_info->num_chipselect;
> [...]
> }
>
> Reducing an indentation level for all the following statements.
Good point, there's nothing else in the platform info to use.
next prev parent reply other threads:[~2017-10-18 17:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 19:54 [PATCH 1/4] spi: imx: GPIO based chip selects should not be required Trent Piepho
[not found] ` <20171013195410.30767-1-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-10-13 19:54 ` [PATCH 2/4] spi: imx: Fix failure path leak on GPIO request error Trent Piepho
[not found] ` <20171013195410.30767-2-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-10-19 10:27 ` Oleksij Rempel
2017-10-13 19:54 ` [PATCH 3/4] spi: imx: Don't require platform data chipselect array Trent Piepho
2017-10-18 9:02 ` Julien Thierry
[not found] ` <36d381de-ee3f-26d4-59c3-b9d361758ace-5wv7dgnIgG8@public.gmane.org>
2017-10-18 17:30 ` Trent Piepho [this message]
2017-10-30 23:47 ` Trent Piepho
2017-10-13 19:54 ` [PATCH 4/4] ARM: imx: Update spi_imx platform data to reflect current state Trent Piepho
[not found] ` <20171013195410.30767-4-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-10-15 23:34 ` Greg Ungerer
2017-10-18 2:17 ` Shawn Guo
2017-10-18 17:50 ` Trent Piepho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508347809.87493.2.camel@impinj.com \
--to=tpiepho-cgc2codaahdqt0dzr+alfa@public.gmane.org \
--cc=fabio.estevam-3arQi8VN3Tc@public.gmane.org \
--cc=gerg-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=julien.thierry-5wv7dgnIgG8@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).