From: Trent Piepho <tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
To: "s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
<s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
<kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"fabio.estevam-3arQi8VN3Tc@public.gmane.org"
<fabio.estevam-3arQi8VN3Tc@public.gmane.org>
Subject: Re: [PATCH v2 1/4] spi: imx: GPIO based chip selects should not be required
Date: Mon, 6 Nov 2017 19:20:41 +0000 [thread overview]
Message-ID: <1509996041.5473.103.camel@impinj.com> (raw)
In-Reply-To: <20171106073246.efcz7r2vnymz3me7-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Mon, 2017-11-06 at 08:32 +0100, Sascha Hauer wrote:
> On Fri, Nov 03, 2017 at 07:18:56PM +0000, Trent Piepho wrote:
> >
> > Comments in the driver indicate that some SoCs do not allow GPIO usage
> > on all chip select pins.
>
> Which comments do you mean? I remember there were comments, but I can't
> find any in the driver.
It's in arch/arm/plat-mxc/include/mach/spi.h.
> The only SoC which has dedicated SPI CS pins which can't be configured
> as GPIOs is the i.MX31. Unless you have an i.MX31 you shouldn't be
> forced to use native chip selects.
Indeed I'm not forced to, but native is more efficient and faster, and
since I'm lucky enough that they work for me, I'd like to be able to
use them. And I can already, but the DT bindings are non-standard and
I don't see any value in that. DT bindings are complex enough without
drivers adding quirks. And my experience was no one connected the non-
standard bindings with native CS not working well. I think explicit
documentation will be more effective at that.
next prev parent reply other threads:[~2017-11-06 19:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 1:08 [PATCH v2 0/4] Fix for imx-spi CS GPIOs Trent Piepho
[not found] ` <20171027010841.28624-1-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-10-27 1:08 ` [PATCH v2 1/4] spi: imx: GPIO based chip selects should not be required Trent Piepho
[not found] ` <20171027010841.28624-2-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-10-31 11:19 ` Mark Brown
[not found] ` <20171031111919.gocl7wwrhkwnxrya-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
2017-10-31 16:57 ` Trent Piepho
[not found] ` <1509469061.5473.16.camel-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-11-02 15:14 ` Mark Brown
[not found] ` <20171102151439.6dpfud7a5vtc27dy-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
2017-11-03 17:53 ` Trent Piepho
[not found] ` <1509731639.5473.60.camel-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-11-03 18:37 ` Mark Brown
[not found] ` <20171103183700.spnqbagr4q7fth4k-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
2017-11-03 19:18 ` Trent Piepho
[not found] ` <1509736735.5473.87.camel-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-11-03 19:36 ` Mark Brown
[not found] ` <20171103193649.jcoiy3raefikko2h-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
2017-11-03 20:09 ` Trent Piepho
[not found] ` <1509739759.5473.93.camel-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-11-03 20:11 ` Mark Brown
2017-11-06 7:32 ` Sascha Hauer
[not found] ` <20171106073246.efcz7r2vnymz3me7-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-11-06 19:20 ` Trent Piepho [this message]
2017-10-27 1:08 ` [PATCH v2 2/4] spi: imx: Fix failure path leak on GPIO request error Trent Piepho
2017-10-27 1:08 ` [PATCH v2 3/4] spi: imx: Don't require platform data chipselect array Trent Piepho
[not found] ` <20171027010841.28624-4-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-10-27 11:14 ` Oleksij Rempel
2017-10-27 1:08 ` [PATCH v2 4/4] ARM: imx: Update spi_imx platform data to reflect current state Trent Piepho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509996041.5473.103.camel@impinj.com \
--to=tpiepho-cgc2codaahdqt0dzr+alfa@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=fabio.estevam-3arQi8VN3Tc@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).