From: Trent Piepho <tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
To: "broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"jan.kundrat-xoNZbkdr4U2lVyrhU4qvOw@public.gmane.org"
<jan.kundrat-xoNZbkdr4U2lVyrhU4qvOw@public.gmane.org>
Cc: "Chris.Packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org"
<Chris.Packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>,
"m-karicheri2-l0cyMroinI0@public.gmane.org"
<m-karicheri2-l0cyMroinI0@public.gmane.org>,
"andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"grygorii.strashko-l0cyMroinI0@public.gmane.org"
<grygorii.strashko-l0cyMroinI0@public.gmane.org>,
"gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org"
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
"linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"christophe.jaillet-39ZsbGIQGT5GWvitb5QawA@public.gmane.org"
<christophe.jaillet-39ZsbGIQGT5GWvitb5QawA@public.gmane.org>,
"geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org"
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Subject: Re: [PATCH 4/4] spi: orion: Software control for inter-word delays
Date: Thu, 15 Feb 2018 17:18:08 +0000 [thread overview]
Message-ID: <1518715087.25567.68.camel@impinj.com> (raw)
In-Reply-To: <20180215154945.GF8374-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1200 bytes --]
On Thu, 2018-02-15 at 15:49 +0000, Mark Brown wrote:
> On Thu, Feb 15, 2018 at 04:45:55PM +0100, Jan Kundrát wrote:
>
> > My most important use case is, however, the userspace-facing spidev, and its
> > ioctl complicates stuff a bit. The relevant struct has a 16bit padding now
> > (used to be 32bit prior to https://patchwork.kernel.org/patch/3715391/). Is
> > it OK to use this padding for this feature? Or should I perhaps eat just
> > 8bits and limit the delays to an arbitrary value of 255us? Or should I not
> > care about that now and let somebody else come up with another "bigger"
> > ioctl when they need that space?
>
> Ugh. Using the whole padding is probably OK.
There could be a flag that switches delay_us from being a post xfer
delay to being a post word delay. Then no need field needs to be added.
If someone wants both a post word and post xfer delay in the same
xfer, then they'll just need to split it, which should be possible
since it must be longer than one word to need a delay after each word.
Not that great either.N§²æìr¸yúèØb²X¬¶Ç§vØ^)Þº{.nÇ+·¥{±²¢Ø^nr¡ö¦zË\x1aëh¨èÚ&¢îý»\x05ËÛÔØï¦v¬Îf\x1dp)¹¹br ê+Ê+zf£¢·h§~Ûiÿûàz¹\x1e®w¥¢¸?¨èÚ&¢)ߢ^[f
next prev parent reply other threads:[~2018-02-15 17:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 14:15 [PATCH 1/4] spi: orion: Make the error message greppable Jan Kundrát
[not found] ` <bc8bf712358fbb000ea7e2ea9e1aec42b21988e6.1518704854.git.jan.kundrat-xoNZbkdr4U2lVyrhU4qvOw@public.gmane.org>
2018-02-10 11:20 ` [PATCH 3/4] spi: orion: Prepare space for per-child options Jan Kundrát
2018-02-10 12:25 ` [PATCH 4/4] spi: orion: Software control for inter-word delays Jan Kundrát
[not found] ` <475b63c52b17187089d3f2ecf8ff4b8c45a7e58b.1518704854.git.jan.kundrat-xoNZbkdr4U2lVyrhU4qvOw@public.gmane.org>
2018-02-15 15:19 ` Mark Brown
[not found] ` <20180215151907.GD8374-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2018-02-15 15:45 ` Jan Kundrát
[not found] ` <c5d27950-0d13-422c-afe9-990b4adad45a-xoNZbkdr4U2lVyrhU4qvOw@public.gmane.org>
2018-02-15 15:49 ` Mark Brown
[not found] ` <20180215154945.GF8374-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2018-02-15 17:18 ` Trent Piepho [this message]
[not found] ` <1518715087.25567.68.camel-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2018-02-15 17:29 ` Mark Brown
2018-02-15 14:19 ` [PATCH 2/4] spi: orion: Respect per-transfer bits_per_word settings Jan Kundrát
[not found] ` <b983963f1ad0400fdca2f8bf8095d25b62b0ffb0.1518704854.git.jan.kundrat-xoNZbkdr4U2lVyrhU4qvOw@public.gmane.org>
2018-02-15 17:13 ` Trent Piepho
[not found] ` <E1emNJK-0004YS-Oj@debutante>
2018-02-15 17:36 ` Applied "spi: orion: Respect per-transfer bits_per_word settings" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518715087.25567.68.camel@impinj.com \
--to=tpiepho-cgc2codaahdqt0dzr+alfa@public.gmane.org \
--cc=Chris.Packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org \
--cc=andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=christophe.jaillet-39ZsbGIQGT5GWvitb5QawA@public.gmane.org \
--cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=grygorii.strashko-l0cyMroinI0@public.gmane.org \
--cc=jan.kundrat-xoNZbkdr4U2lVyrhU4qvOw@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m-karicheri2-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).