From: Sean Wang <sean.wang@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: <matthias.bgg@gmail.com>, <linux-spi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi: mediatek: remove redundant MODULE_ALIAS entries
Date: Wed, 28 Mar 2018 11:09:03 +0800 [thread overview]
Message-ID: <1522206543.18424.23.camel@mtkswgap22> (raw)
In-Reply-To: <20180328021416.GK29239@sirena.org.uk>
On Wed, 2018-03-28 at 10:14 +0800, Mark Brown wrote:
> On Mon, Mar 26, 2018 at 06:04:18PM +0800, sean.wang@mediatek.com wrote:
> > From: Sean Wang <sean.wang@mediatek.com>
> >
> > MODULE_ALIAS exports information to allow the module to be auto-loaded at
> > boot for the drivers registered using legacy platform registration.
> >
> > However, currently the driver is always used by DT-only platform,
> > MODULE_ALIAS is redundant and should be removed properly.
>
> There is no meaningful cost to having the alias there, why remove it?
It's no explicitly improved to the driver, it only takes less bytes
in .secion modinfo from 644 bytes to 620 bytes in the observation with
objdump.
More importantly, it seems the driver should probably refer to another
qualified driver at the initial development, but MODULE_ALIAS is
forgetting to be removed to meet real usage for the module autoload.
Even I was curious whether people for the driver know the actual purpose
the macro it's for.
Removing MODULE_ALIAS is just to correct the driver to where it should
be.
next prev parent reply other threads:[~2018-03-28 3:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 10:04 [PATCH] spi: mediatek: remove redundant MODULE_ALIAS entries sean.wang
2018-03-28 2:14 ` Mark Brown
2018-03-28 3:09 ` Sean Wang [this message]
2018-04-12 16:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522206543.18424.23.camel@mtkswgap22 \
--to=sean.wang@mediatek.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).